Feature: proper unit test case for voucher

Author: 1yam

tests/unit/conftest.py

@@ -13,12 +13,12 @@
 from datetime import datetime, timezone
 from pathlib import Path
 from tempfile import NamedTemporaryFile
-from unittest.mock import AsyncMock, patch
+from unittest.mock import AsyncMock, MagicMock, patch
 
 import pytest
 from aleph.sdk.chains.common import generate_key
 from aleph.sdk.chains.ethereum import ETHAccount, get_fallback_private_key
-from aleph.sdk.types import StoredContent
+from aleph.sdk.types import StoredContent, Voucher, VoucherAttribute
 from aleph_message.models import Chain, ItemHash, ItemType, StoreContent, StoreMessage
 from aleph_message.models.base import MessageType
 
@@ -37,6 +37,12 @@
     FAKE_STORE_HASH,
 )
 
+# Constants for voucher testing
+MOCK_ADDRESS = "0x1234567890123456789012345678901234567890"
+MOCK_SOLANA_ADDRESS = "abcdefghijklmnopqrstuvwxyz123456789"
+MOCK_METADATA_ID = "metadata123"
+MOCK_VOUCHER_ID = "voucher123"
+
 
 @pytest.fixture
 def new_config_file() -> Generator[Path, None, None]:
@@ -466,3 +472,55 @@ async def mock_json():
         instance.get = AsyncMock(return_value=mock_response)
 
         yield mock_session
+
+
+@pytest.fixture
+def mock_vouchers():
+    """Create mock vouchers for testing."""
+    # Create EVM voucher
+    evm_voucher = Voucher(
+        id=MOCK_VOUCHER_ID,
+        metadata_id=MOCK_METADATA_ID,
+        name="EVM Test Voucher",
+        description="A test voucher for EVM chains",
+        external_url="https://example.com",
+        image="https://example.com/image.png",
+        icon="https://example.com/icon.png",
+        attributes=[
+            VoucherAttribute(trait_type="Duration", value="30 days", display_type="string"),
+            VoucherAttribute(trait_type="Compute Units", value="4", display_type="number"),
+            VoucherAttribute(trait_type="Type", value="instance", display_type="string"),
+        ],
+    )
+
+    # Create Solana voucher
+    solana_voucher = Voucher(
+        id="solticket123",
+        metadata_id=MOCK_METADATA_ID,
+        name="Solana Test Voucher",
+        description="A test voucher for Solana",
+        external_url="https://example.com",
+        image="https://example.com/image.png",
+        icon="https://example.com/icon.png",
+        attributes=[
+            VoucherAttribute(trait_type="Duration", value="60 days", display_type="string"),
+            VoucherAttribute(trait_type="Compute Units", value="8", display_type="number"),
+            VoucherAttribute(trait_type="Type", value="instance", display_type="string"),
+        ],
+    )
+
+    return evm_voucher, solana_voucher
+
+
+@pytest.fixture
+def mock_voucher_service(mock_vouchers):
+    """Create a mock voucher service with pre-configured responses."""
+    evm_voucher, solana_voucher = mock_vouchers
+
+    mock_service = MagicMock()
+    mock_service.fetch_vouchers_by_chain = AsyncMock(return_value=[evm_voucher])
+    mock_service.get_vouchers = AsyncMock(return_value=[evm_voucher, solana_voucher])
+    mock_service.get_evm_vouchers = AsyncMock(return_value=[evm_voucher])
+    mock_service.get_solana_vouchers = AsyncMock(return_value=[solana_voucher])
+
+    return mock_service

tests/unit/test_commands.py

@@ -244,7 +244,7 @@ def test_account_sign_bytes(env_files):
     assert result.stdout.startswith("\nSignature:")
 
 
-def test_account_balance(mocker, env_files):
+def test_account_balance(mocker, env_files, mock_voucher_service):
     settings.CONFIG_FILE = env_files[1]
     balance_response = {
         "address": "0xCAfEcAfeCAfECaFeCaFecaFecaFECafECafeCaFe",
@@ -255,14 +255,19 @@ def test_account_balance(mocker, env_files):
     }
 
     mocker.patch("aleph_client.commands.account.get_balance", return_value=balance_response)
-    mocker.patch("aleph_client.voucher.VoucherManager.get_all", return_value=[])
+    # TODO: used the mocked_client fixture instead (also need to move get_balance to the SDK)
+    mock_client = mocker.AsyncMock()
+    mock_client.voucher = mock_voucher_service
+    mocker.patch("aleph_client.commands.account.AuthenticatedAlephHttpClient.__aenter__", return_value=mock_client)
 
     result = runner.invoke(
         app, ["account", "balance", "--address", "0xCAfEcAfeCAfECaFeCaFecaFecaFECafECafeCaFe", "--chain", "ETH"]
     )
     assert result.exit_code == 0
     assert result.stdout.startswith("╭─ Account Infos")
     assert "Available: 20189.67" in result.stdout
+    assert "Vouchers:" in result.stdout
+    assert "EVM Test Voucher" in result.stdout
 
 
 def test_account_balance_error(mocker, env_files):

tests/unit/test_instance.py

@@ -47,6 +47,7 @@
 )
 from aleph_client.utils import FORBIDDEN_HOSTS, sanitize_url
 
+from .conftest import MOCK_METADATA_ID, MOCK_VOUCHER_ID
 from .mocks import (
     FAKE_ADDRESS_EVM,
     FAKE_CRN_BASIC_HASH,
@@ -254,7 +255,7 @@ def create_mock_shutil():
     return MagicMock(which=MagicMock(return_value="/root/.cargo/bin/sevctl", move=MagicMock(return_value="/fake/path")))
 
 
-def create_mock_client(mock_crn_list, payment_type="superfluid"):
+def create_mock_client(mock_crn_list, payment_type="superfluid", mock_voucher_service=None):
     # Create a proper mock for the crn service
     mock_crn_service = MagicMock()
     mock_crn_service.get_crns_list = AsyncMock(return_value={"crns": mock_crn_list})
@@ -271,11 +272,13 @@ def create_mock_client(mock_crn_list, payment_type="superfluid"):
             )
         ),
     )
-    # Set the crn attribute to the properly mocked service
+    # Set the service attributes
     mock_client.crn = mock_crn_service
+    mock_client.voucher = mock_voucher_service
 
     mock_client_class = MagicMock()
     mock_client_class.return_value.__aenter__ = AsyncMock(return_value=mock_client)
+
     return mock_client_class, mock_client
 
 
@@ -291,6 +294,48 @@ def response_get_program_price(ptype):
     mock_crn_service = MagicMock()
     mock_crn_service.get_crns_list = AsyncMock(return_value={"crns": mock_crn_list or []})
 
+    # Create voucher attributes using the proper types
+    from aleph.sdk.types import Voucher, VoucherAttribute
+
+    # Create EVM voucher
+    evm_voucher = Voucher(
+        id=MOCK_VOUCHER_ID,
+        metadata_id=MOCK_METADATA_ID,
+        name="EVM Test Voucher",
+        description="A test voucher for EVM chains",
+        external_url="https://example.com",
+        image="https://example.com/image.png",
+        icon="https://example.com/icon.png",
+        attributes=[
+            VoucherAttribute(trait_type="Duration", value="30 days", display_type="string"),
+            VoucherAttribute(trait_type="Compute Units", value="4", display_type="number"),
+            VoucherAttribute(trait_type="Type", value="instance", display_type="string"),
+        ],
+    )
+
+    # Create Solana voucher
+    solana_voucher = Voucher(
+        id="solticket123",
+        metadata_id=MOCK_METADATA_ID,
+        name="Solana Test Voucher",
+        description="A test voucher for Solana",
+        external_url="https://example.com",
+        image="https://example.com/image.png",
+        icon="https://example.com/icon.png",
+        attributes=[
+            VoucherAttribute(trait_type="Duration", value="60 days", display_type="string"),
+            VoucherAttribute(trait_type="Compute Units", value="8", display_type="number"),
+            VoucherAttribute(trait_type="Type", value="instance", display_type="string"),
+        ],
+    )
+
+    # Create a proper mock for voucher service
+    mock_voucher_service = MagicMock()
+    mock_voucher_service.fetch_vouchers_by_chain = AsyncMock(return_value=[evm_voucher])
+    mock_voucher_service.get_vouchers = AsyncMock(return_value=[evm_voucher, solana_voucher])
+    mock_voucher_service.get_evm_vouchers = AsyncMock(return_value=[evm_voucher])
+    mock_voucher_service.get_solana_vouchers = AsyncMock(return_value=[solana_voucher])
+
     mock_response_get_message = create_mock_instance_message(mock_account, payg=True)
     mock_response_create_instance = MagicMock(item_hash=FAKE_VM_HASH)
 
@@ -312,6 +357,7 @@ def response_get_program_price(ptype):
     # Set the service attributes
     mock_auth_client.crn = mock_crn_service
     mock_auth_client.port_forwarder = mock_port_forwarder
+    mock_auth_client.voucher = mock_voucher_service
 
     if payment_types:
         mock_auth_client.get_program_price = AsyncMock(
@@ -374,6 +420,9 @@ def create_mock_vm_coco_client():
         "coco_hold_evm",
         "coco_superfluid_evm",
         "gpu_superfluid_evm",
+        "nft_payment_avax",
+        "nft_payment_base",
+        "nft_payment_sol",
     ],
     argnames="args, expected",
     argvalues=[
@@ -445,6 +494,32 @@ def create_mock_vm_coco_client():
             },
             (FAKE_VM_HASH, FAKE_CRN_GPU_URL, "BASE"),
         ),
+        (  # nft_payment_avax
+            {
+                "payment_type": "nft",
+                "payment_chain": "AVAX",
+                "rootfs": "debian12",
+            },
+            (FAKE_VM_HASH, None, "AVAX"),
+        ),
+        (  # nft_payment_base
+            {
+                "payment_type": "nft",
+                "payment_chain": "BASE",
+                "rootfs": "debian12",
+                "crn_url": FAKE_CRN_BASIC_URL,
+            },
+            (FAKE_VM_HASH, None, "BASE"),
+        ),
+        (  # nft_payment_sol
+            {
+                "payment_type": "nft",
+                "payment_chain": "SOL",
+                "rootfs": "debian12",
+                "crn_url": FAKE_CRN_BASIC_URL,
+            },
+            (FAKE_VM_HASH, None, "SOL"),
+        ),
     ],
 )
 @pytest.mark.asyncio