refactor: using with patch.objects instead of direcly assign method for mypy

Author: 1yam

tests/unit/services/test_voucher.py

@@ -20,18 +20,18 @@ async def test_get_evm_vouchers(mock_post_response, make_mock_aiohttp_session):
     client = AlephHttpClient(api_server="http://localhost")
 
     # Patch only the get_posts who is used to fetch voucher update for EVM
-    client.get_posts = AsyncMock(return_value=mock_post_response)
-    voucher_service = Vouchers(client=client)
+    with patch.object(client, "get_posts", AsyncMock(return_value=mock_post_response)):
+        voucher_service = Vouchers(client=client)
 
-    session = make_mock_aiohttp_session(MOCK_METADATA)
+        session = make_mock_aiohttp_session(MOCK_METADATA)
 
-    # Here we patch the client sessions who gonna fetch the metdata of the NFT
-    with patch("aiohttp.ClientSession", return_value=session):
-        vouchers = await voucher_service.get_evm_vouchers(MOCK_ADDRESS)
+        # Here we patch the client sessions who gonna fetch the metdata of the NFT
+        with patch("aiohttp.ClientSession", return_value=session):
+            vouchers = await voucher_service.get_evm_vouchers(MOCK_ADDRESS)
 
-    assert len(vouchers) == 1
-    assert vouchers[0].id == MOCK_VOUCHER_ID
-    assert vouchers[0].name == MOCK_METADATA["name"]
+        assert len(vouchers) == 1
+        assert vouchers[0].id == MOCK_VOUCHER_ID
+        assert vouchers[0].name == MOCK_METADATA["name"]
 
 
 @pytest.mark.asyncio
@@ -61,17 +61,17 @@ async def test_fetch_vouchers_by_chain_for_evm(
     mock_post_response, make_mock_aiohttp_session
 ):
     client = AlephHttpClient(api_server="http://localhost")
-    client.get_posts = AsyncMock(return_value=mock_post_response)
-    voucher_service = Vouchers(client=client)
+    with patch.object(client, "get_posts", AsyncMock(return_value=mock_post_response)):
+        voucher_service = Vouchers(client=client)
 
-    metadata_session = make_mock_aiohttp_session(MOCK_METADATA)
-    with patch("aiohttp.ClientSession", return_value=metadata_session):
-        vouchers = await voucher_service.fetch_vouchers_by_chain(
-            Chain.ETH, MOCK_ADDRESS
-        )
+        metadata_session = make_mock_aiohttp_session(MOCK_METADATA)
+        with patch("aiohttp.ClientSession", return_value=metadata_session):
+            vouchers = await voucher_service.fetch_vouchers_by_chain(
+                Chain.ETH, MOCK_ADDRESS
+            )
 
-    assert len(vouchers) == 1
-    assert vouchers[0].id == "voucher123"
+        assert len(vouchers) == 1
+        assert vouchers[0].id == "voucher123"
 
 
 @pytest.mark.asyncio
@@ -98,23 +98,23 @@ async def test_get_vouchers_detects_chain(
     make_mock_aiohttp_session, mock_post_response
 ):
     client = AlephHttpClient(api_server="http://localhost")
-    client.get_posts = AsyncMock(return_value=mock_post_response)
-    voucher_service = Vouchers(client=client)
-
-    # EVM
-    metadata_session = make_mock_aiohttp_session(MOCK_METADATA)
-    with patch("aiohttp.ClientSession", return_value=metadata_session):
-        vouchers = await voucher_service.get_vouchers(MOCK_ADDRESS)
-        assert len(vouchers) == 1
-        assert vouchers[0].id == "voucher123"
-
-    # Solana
-    registry_session = make_mock_aiohttp_session(MOCK_SOLANA_REGISTRY)
-    metadata_session = make_mock_aiohttp_session(MOCK_METADATA)
-
-    with patch(
-        "aiohttp.ClientSession", side_effect=[registry_session, metadata_session]
-    ):
-        vouchers = await voucher_service.get_vouchers(MOCK_SOLANA_ADDRESS)
-        assert len(vouchers) == 1
-        assert vouchers[0].id == "solticket123"
+    with patch.object(client, "get_posts", AsyncMock(return_value=mock_post_response)):
+        voucher_service = Vouchers(client=client)
+
+        # EVM
+        metadata_session = make_mock_aiohttp_session(MOCK_METADATA)
+        with patch("aiohttp.ClientSession", return_value=metadata_session):
+            vouchers = await voucher_service.get_vouchers(MOCK_ADDRESS)
+            assert len(vouchers) == 1
+            assert vouchers[0].id == "voucher123"
+
+        # Solana
+        registry_session = make_mock_aiohttp_session(MOCK_SOLANA_REGISTRY)
+        metadata_session = make_mock_aiohttp_session(MOCK_METADATA)
+
+        with patch(
+            "aiohttp.ClientSession", side_effect=[registry_session, metadata_session]
+        ):
+            vouchers = await voucher_service.get_vouchers(MOCK_SOLANA_ADDRESS)
+            assert len(vouchers) == 1
+            assert vouchers[0].id == "solticket123"