fix: move fixture / metdata for voucher to conftest.py

Author: 1yam

tests/unit/conftest.py

@@ -306,3 +306,65 @@ def post(self, *_args, **_kwargs):
     client._http_session = http_session
 
     return client
+
+
+@pytest.fixture
+def make_mock_aiohttp_session():
+    def _make(mocked_json_response):
+        mock_response = AsyncMock()
+        mock_response.json.return_value = mocked_json_response
+        mock_response.raise_for_status.return_value = None
+
+        session = MagicMock()
+
+        get_cm = AsyncMock()
+        get_cm.__aenter__.return_value = mock_response
+        session.get.return_value = get_cm
+
+        session_cm = AsyncMock()
+        session_cm.__aenter__.return_value = session
+        return session_cm
+
+    return _make
+
+
+# Constants needed for voucher tests
+MOCK_ADDRESS = "0x1234567890123456789012345678901234567890"
+MOCK_SOLANA_ADDRESS = "abcdefghijklmnopqrstuvwxyz123456789"
+MOCK_METADATA_ID = "metadata123"
+MOCK_VOUCHER_ID = "voucher123"
+MOCK_METADATA = {
+    "name": "Test Voucher",
+    "description": "A test voucher",
+    "external_url": "https://example.com",
+    "image": "https://example.com/image.png",
+    "icon": "https://example.com/icon.png",
+    "attributes": [
+        {"trait_type": "Test Trait", "value": "Test Value"},
+        {"trait_type": "Numeric Trait", "value": "123", "display_type": "number"},
+    ],
+}
+
+MOCK_EVM_VOUCHER_DATA = [
+    (MOCK_VOUCHER_ID, {"claimer": MOCK_ADDRESS, "metadata_id": MOCK_METADATA_ID})
+]
+
+MOCK_SOLANA_REGISTRY = {
+    "claimed_tickets": {
+        "solticket123": {"claimer": MOCK_SOLANA_ADDRESS, "batch_id": "batch123"}
+    },
+    "batches": {"batch123": {"metadata_id": MOCK_METADATA_ID}},
+}
+
+
+@pytest.fixture
+def mock_post_response():
+    mock_post = MagicMock()
+    mock_post.content = {
+        "nft_vouchers": {
+            MOCK_VOUCHER_ID: {"claimer": MOCK_ADDRESS, "metadata_id": MOCK_METADATA_ID}
+        }
+    }
+    posts_response = MagicMock()
+    posts_response.posts = [mock_post]
+    return posts_response

tests/unit/services/test_authenticated_voucher.py

@@ -4,7 +4,7 @@
 
 from aleph.sdk.client.services.authenticated_voucher import AuthenticatedVoucher
 
-from .test_voucher import (
+from ..conftest import (
     MOCK_ADDRESS,
     MOCK_METADATA,
     MOCK_SOLANA_ADDRESS,

tests/unit/services/test_voucher.py

@@ -5,66 +5,13 @@
 
 from aleph.sdk.client.services.voucher import Vouchers
 
-MOCK_ADDRESS = "0x1234567890123456789012345678901234567890"
-MOCK_SOLANA_ADDRESS = "abcdefghijklmnopqrstuvwxyz123456789"
-
-MOCK_METADATA_ID = "metadata123"
-MOCK_VOUCHER_ID = "voucher123"
-MOCK_METADATA = {
-    "name": "Test Voucher",
-    "description": "A test voucher",
-    "external_url": "https://example.com",
-    "image": "https://example.com/image.png",
-    "icon": "https://example.com/icon.png",
-    "attributes": [
-        {"trait_type": "Test Trait", "value": "Test Value"},
-        {"trait_type": "Numeric Trait", "value": "123", "display_type": "number"},
-    ],
-}
-
-MOCK_EVM_VOUCHER_DATA = [
-    (MOCK_VOUCHER_ID, {"claimer": MOCK_ADDRESS, "metadata_id": MOCK_METADATA_ID})
-]
-
-MOCK_SOLANA_REGISTRY = {
-    "claimed_tickets": {
-        "solticket123": {"claimer": MOCK_SOLANA_ADDRESS, "batch_id": "batch123"}
-    },
-    "batches": {"batch123": {"metadata_id": MOCK_METADATA_ID}},
-}
-
-
-@pytest.fixture
-def make_mock_aiohttp_session():
-    def _make(mocked_json_response):
-        mock_response = AsyncMock()
-        mock_response.json.return_value = mocked_json_response
-        mock_response.raise_for_status.return_value = None
-
-        session = MagicMock()
-
-        get_cm = AsyncMock()
-        get_cm.__aenter__.return_value = mock_response
-        session.get.return_value = get_cm
-
-        session_cm = AsyncMock()
-        session_cm.__aenter__.return_value = session
-        return session_cm
-
-    return _make
-
-
-@pytest.fixture
-def mock_post_response():
-    mock_post = MagicMock()
-    mock_post.content = {
-        "nft_vouchers": {
-            MOCK_VOUCHER_ID: {"claimer": MOCK_ADDRESS, "metadata_id": MOCK_METADATA_ID}
-        }
-    }
-    posts_response = MagicMock()
-    posts_response.posts = [mock_post]
-    return posts_response
+from ..conftest import (
+    MOCK_ADDRESS,
+    MOCK_METADATA,
+    MOCK_SOLANA_ADDRESS,
+    MOCK_SOLANA_REGISTRY,
+    MOCK_VOUCHER_ID,
+)
 
 
 @pytest.mark.asyncio