Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for password hints #32

Open
alichtman opened this issue Sep 3, 2019 · 1 comment
Open

Add support for password hints #32

alichtman opened this issue Sep 3, 2019 · 1 comment
Assignees
@shobrook @alichtman

Comments

@alichtman
Copy link
Owner

alichtman commented Sep 3, 2019 •
edited
Loading

Add fixed-size buffer at head of encrypted file for password hint.

Need a UI element, as well.
@alichtman alichtman changed the title Add password hints Add support for password hints Sep 3, 2019
@alichtman alichtman mentioned this issue Jan 17, 2025
Closed
@alichtman alichtman marked this as a duplicate of #52 Jan 17, 2025
@alichtman
Copy link
Owner Author

This needs to be done in a backwards-compatible way, which is tricky, since I was kind of dumb when I put together the original spec. I left ... 0 bytes extra to play with.

One option is dropping a binary header at the end of the metadata, with a marker like PASSWORD_HINT_HEADER:LENGTH:<HINT>, and detect that a hint has been added to this file by the existence of PASSWORD_HINT_HEADER.

If that binary string were to happen to be the start of the payload, the file would be corrupted for decryption, and that's not ok.

On one hand, maybe it's so unlikely to happen that it's fine. On the other hand, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shobrook shobrook

@alichtman alichtman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shobrook @alichtman