Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Decouple client router from server URL resolution #4936

Open
coderabbitai bot opened this issue Feb 13, 2025 · 0 comments
Open

Refactor: Decouple client router from server URL resolution #4936

coderabbitai bot opened this issue Feb 13, 2025 · 0 comments
Assignees

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2025

Context

Currently, the server is tightly coupled with client routing by building and parsing entity URLs with specific path segments (challenges, opportunities).

This was discussed in PR #4883.

Issues

  1. Changes to client routes require server changes
  2. Specific naming (challenge, opportunity) instead of generic levels (L0, L1, L2)

Suggested Improvements

  1. Server should get generic entity information instead of parsing URLs:
{
  type: "opportunity",
  spaceNameId: "",
  challengeNameId: "",
  opportunityNameId: ""
}
  1. Let clients define their own routes;
  2. Let the client decide what information is needed, not the server;
  3. Consider using naming like spaceNameL0, spaceNameL1, spaceNameL2

Benefits

  • Decoupled client routing from server
  • More robust architecture
  • Easier to maintain and modify routes
  • Generic naming allows for future flexibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant