-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Description
in #940 we discussed with @JimMadge that our CI is a bit fragmented as is. It would be nice to consider consolidating these workflows into one or two that thoughtfully run the appropriate parts of our checks and tests.
My comments are belo
LINT: checks for linting
OFFLINE links: is what you just created. It builds the docs and runs link check
WIP: I believe it is an APP that looks for WIP in the title of the PR. We might be able to remove that, given there are draft pr's now? But I may be missing something.
What I'm noticing is that we don't have an explicit build docs CI label here, so when you go to approve it, it appears that the build docs step didn't happen, but it actually occurs in the offline link check step.
Should we rename that workshop to be build docs and check links just to make the CI steps above more expressive? It's a minor suggestion, but I started to think that we needed to run build docs and then realized that may be redundant. I am curious what you think. Alternatively, we could merge the two workflows (build and deploy, and link check) together and put a condition on the deploy step.
Part 1 would be building documentation, running Lychee.
Part 2 would be deploy with a conditional:
if branch == main, deploy
Originally posted by @lwasser in #940 (comment)
Thoughts, Jim?