Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimals in JSON subscriptions of Avro topics are invalid #1808

Open
moscicky opened this issue Dec 22, 2023 · 5 comments
Open

Decimals in JSON subscriptions of Avro topics are invalid #1808

moscicky opened this issue Dec 22, 2023 · 5 comments

Comments

@moscicky
Copy link
Collaborator

Test that reproduces the bug: b9773ce

org.opentest4j.AssertionFailedError: 
expected: "1.20"
 but was: "x"
@MateuszDobrowolski
Copy link
Collaborator

Can i take care of it? : )

@szczygiel-m
Copy link
Contributor

Hi, sure 😄 in case of any questions/problems feel free to ask

@MateuszDobrowolski
Copy link
Collaborator

@szczygiel-m I have prepared the proposition of the fix. Could I ask for permission to create a draft PR?

@MateuszDobrowolski
Copy link
Collaborator

MateuszDobrowolski commented Oct 31, 2024

Proposal: During AVRO-to-JSON conversion, we transform messages with the logical decimal type into a BigDecimal and then into a String. This ensures that subscription consumers receive the decimal value as String rather than the byte buffer contents. This conversion does not apply to AVRO-to-JSON conversion for previews of messages published to the topic.

Changes in json-avro-converter repo: allegro/json-avro-converter#87
Changes in hermes: #1957

MateuszDobrowolski added a commit to MateuszDobrowolski/json-avro-converter that referenced this issue Mar 10, 2025
MateuszDobrowolski added a commit to MateuszDobrowolski/json-avro-converter that referenced this issue Mar 10, 2025
MateuszDobrowolski added a commit to MateuszDobrowolski/json-avro-converter that referenced this issue Mar 10, 2025
MateuszDobrowolski added a commit to MateuszDobrowolski/json-avro-converter that referenced this issue Mar 10, 2025
MateuszDobrowolski added a commit to MateuszDobrowolski/json-avro-converter that referenced this issue Mar 10, 2025
MateuszDobrowolski added a commit to MateuszDobrowolski/json-avro-converter that referenced this issue Mar 10, 2025
MateuszDobrowolski added a commit to MateuszDobrowolski/json-avro-converter that referenced this issue Mar 10, 2025
MateuszDobrowolski added a commit to MateuszDobrowolski/json-avro-converter that referenced this issue Mar 10, 2025
MateuszDobrowolski added a commit to MateuszDobrowolski/json-avro-converter that referenced this issue Mar 10, 2025
MateuszDobrowolski added a commit to MateuszDobrowolski/json-avro-converter that referenced this issue Mar 10, 2025
MateuszDobrowolski added a commit that referenced this issue Mar 17, 2025
@MateuszDobrowolski
Copy link
Collaborator

Could I ask you, @moscicky to take a look at this or give me a tip about whom I should talk about the solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants