-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decimals in JSON subscriptions of Avro topics are invalid #1808
Comments
Can i take care of it? : ) |
Hi, sure 😄 in case of any questions/problems feel free to ask |
@szczygiel-m I have prepared the proposition of the fix. Could I ask for permission to create a draft PR? |
Proposal: During AVRO-to-JSON conversion, we transform messages with the logical decimal type into a BigDecimal and then into a String. This ensures that subscription consumers receive the decimal value as String rather than the byte buffer contents. This conversion does not apply to AVRO-to-JSON conversion for previews of messages published to the topic. Changes in json-avro-converter repo: allegro/json-avro-converter#87 |
This reverts commit a90462f.
This reverts commit 55469b7.
Could I ask you, @moscicky to take a look at this or give me a tip about whom I should talk about the solution? |
Test that reproduces the bug: b9773ce
The text was updated successfully, but these errors were encountered: