Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit scss linting ordering rule #1899

Open
vanitabarrett opened this issue Aug 4, 2020 · 0 comments
Open

Revisit scss linting ordering rule #1899

vanitabarrett opened this issue Aug 4, 2020 · 0 comments

Comments

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Aug 4, 2020

This is a stretch goal following on from #1740

Our linting checks that CSS properties are in a particular order. We kept this behaviour when switching from sass-lint to stylelint, but as a linting rule unique to GOVUK Frontend (stylelint-config-gds does not include this rule by default). This means our repo now has a custom linting rule compared to other projects which may use the config as is.

  • Are we ok with having a custom rule?
  • Do we think the ordering rule is necessary? What are the pros and cons?
  • What would the impact be of turning the rule off?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant