Skip to content

Commit 831b34d

Browse files
committed
Don’t freeze self into requirements file
This results in the local development path (in this case Leo’s) being frozen into the requirements file. Instead we can: - freeze only the requirements from `setup.py` into our test requirements file - tell tox to install this package as a separate step
1 parent c1117d4 commit 831b34d

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ help:
99
freeze-requirements: ## Freeze requirements files
1010
pip install -r requirements.txt
1111
python -c "from notifications_utils.version_tools import copy_config; copy_config()"
12-
pip-compile requirements_for_test.in
12+
pip-compile -o requirements_for_test.txt setup.py requirements_for_test.in
1313

1414
.PHONY: bootstrap
1515
bootstrap: ## Install build dependencies

requirements_for_test.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
.
21
-r requirements_for_test_common.in
32

43
jsonschema>=2.5.1

requirements_for_test.txt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# This file is autogenerated by pip-compile with Python 3.11
33
# by the following command:
44
#
5-
# pip-compile requirements_for_test.in
5+
# pip-compile --output-file=requirements_for_test.txt requirements_for_test.in setup.py
66
#
77
attrs==24.2.0
88
# via
@@ -25,7 +25,7 @@ coverage==7.6.4
2525
# via pytest-testmon
2626
docopt==0.6.2
2727
# via
28-
# notifications-python-client
28+
# notifications-python-client (setup.py)
2929
# pytest-watch
3030
execnet==2.1.1
3131
# via pytest-xdist
@@ -41,8 +41,6 @@ jsonschema-specifications==2024.10.1
4141
# via jsonschema
4242
mypy-extensions==1.0.0
4343
# via black
44-
notifications-python-client @ file:///Users/leo.hemsted/dev/python-client
45-
# via -r requirements_for_test.in
4644
packaging==24.2
4745
# via
4846
# black
@@ -54,7 +52,7 @@ platformdirs==4.3.6
5452
pluggy==1.5.0
5553
# via pytest
5654
pyjwt==2.9.0
57-
# via notifications-python-client
55+
# via notifications-python-client (setup.py)
5856
pytest==7.2.0
5957
# via
6058
# -r requirements_for_test_common.in
@@ -81,7 +79,7 @@ referencing==0.35.1
8179
# jsonschema-specifications
8280
requests==2.32.3
8381
# via
84-
# notifications-python-client
82+
# notifications-python-client (setup.py)
8583
# requests-mock
8684
requests-mock==1.10.0
8785
# via -r requirements_for_test_common.in

tox.ini

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ envlist =
55
[testenv]
66
allowlist_externals = make
77
deps=
8+
.
89
-r requirements_for_test.in
910
commands =
1011
make test

0 commit comments

Comments
 (0)