Fix yamllint offenses

Author: alexandermeindl

.yamllint

@@ -11,6 +11,8 @@ rules:
   braces: {max-spaces-inside: 1, level: error}
   brackets: {max-spaces-inside: 1, level: error}
   comments-indentation: disable
+  comments: { min-spaces-from-content: 1 }
+  octal-values: { forbid-implicit-octal: true, forbid-explicit-octal: true }
   # indentation: disable
   #  key-duplicates: enable
   #  truthy: disable

roles/ansible_node/tasks/hosts.yml

@@ -11,7 +11,7 @@
   ansible.builtin.copy:
     src: 'ansible/hosts/{{ ansible_node_identifier }}'
     dest: '{{ ansible_node_etc_dir }}/hosts'
-    mode: 0644
+    mode: '0644'
   when:
     - custom_host_file is defined
     - custom_host_file.stat.exists
@@ -20,5 +20,5 @@
   ansible.builtin.copy:
     src: 'ansible/hosts/default_host'
     dest: '{{ ansible_node_etc_dir }}/hosts'
-    mode: 0644
+    mode: '0644'
   when: custom_host_file is undefined or not custom_host_file.stat.exists

roles/ansible_node/tasks/instance.yml

@@ -37,7 +37,7 @@
       ansible.builtin.template:
         src: playbooks/{{ available_playbook.playbook }}.j2
         dest: '{{ playbook_filename }}'
-        mode: 0640
+        mode: '0640'
 
     - name: Prepare timer - {{ available_playbook_name }}
       ansible.builtin.set_fact:

roles/ansible_node/tasks/setup.yml

@@ -49,19 +49,19 @@
   ansible.builtin.file:
     path: '{{ ansible_node_etc_dir }}'
     state: directory
-    mode: 0755
+    mode: '0755'
 
 - name: Check if ansible playbooks directory exist
   ansible.builtin.file:
     path: '{{ ansible_node_playbook_dir }}'
     state: directory
-    mode: 0755
+    mode: '0755'
 
 - name: Ansible configuration
   ansible.builtin.template:
     src: ansible.j2
     dest: /etc/ansible/ansible.cfg
-    mode: 0644
+    mode: '0644'
 
 - name: Install ansible roles
   ansible.builtin.command: "{{ ansible_node_playbook_galaxy_script }} role {{ item.action | default('install') }} {{ item.name }}"

roles/apt/tasks/unattended.yml

@@ -5,7 +5,7 @@
   ansible.builtin.template:
     src: apt/apt.conf.d/{{ item }}.j2
     dest: /etc/apt/apt.conf.d/{{ item }}
-    mode: 0644
+    mode: '0644'
   loop:
     - 20auto-upgrades
     - 50unattended-upgrades
@@ -24,7 +24,7 @@
     state: directory
     owner: root
     group: root
-    mode: 0755
+    mode: '0755'
   loop:
     - /etc/systemd/system/apt-daily.timer.d
     - /etc/systemd/system/apt-daily-upgrade.timer.d
@@ -36,7 +36,7 @@
     dest: /etc/systemd/system/apt-daily.timer.d/override.conf
     owner: root
     group: root
-    mode: 0644
+    mode: '0644'
   notify: Restart apt-daily.timer
 
 # to install the upgrades (unattended-upgrade)
@@ -46,5 +46,5 @@
     dest: /etc/systemd/system/apt-daily-upgrade.timer.d/override.conf
     owner: root
     group: root
-    mode: 0644
+    mode: '0644'
   notify: Restart apt-daily-upgrade.timer

roles/barman/tasks/setup.yml

@@ -18,15 +18,15 @@
   ansible.builtin.template:
     src: 'barman.conf.j2'
     dest: '/etc/barman.conf'
-    mode: 0644
+    mode: '0644'
 
 - name: Make sure .ssh directory exists
   ansible.builtin.file:
     path: '{{ barman_home }}/.ssh'
     state: directory
     owner: '{{ barman_user }}'
     group: '{{ barman_group }}'
-    mode: 0700
+    mode: '0700'
 
 - name: Configure postgres ssh server access
   ansible.posix.authorized_key:
@@ -45,22 +45,22 @@
     dest: '{{ barman_home }}/.ssh/id_rsa'
     owner: '{{ barman_user }}'
     group: '{{ barman_group }}'
-    mode: 0600
+    mode: '0600'
 
 - name: Install .pgpass for barman
   ansible.builtin.template:
     src: pgpass.j2
     dest: '{{ barman_home }}/.pgpass'
     owner: '{{ barman_user }}'
     group: '{{ barman_group }}'
-    mode: 0600
+    mode: '0600'
   when: barman_db_servers | length
 
 - name: SSH server configurations
   ansible.builtin.template:
     src: server.conf.j2
     dest: '/etc/barman.d/{{ item.name }}.conf'
-    mode: 0644
+    mode: '0644'
   loop: '{{ barman_db_servers }}'
 
 - name: Connection check (ssh) to DB Server

roles/cifs_mount/tasks/setup_instance.yml

@@ -27,7 +27,7 @@
   ansible.builtin.template:
     src: credentials_file.j2
     dest: '{{ credentials_file }}'
-    mode: 0600
+    mode: '0600'
   when:
     - cifs_mount.credential_user is defined
     - cifs_mount.credential_password is defined

roles/dendrite/defaults/main.yml

@@ -108,7 +108,7 @@ dendrite_jetstream_storage_path: "{{ dendrite_home_dir }}/matrix-nats-store"
 dendrite_media_api_base_path: "{{ dendrite_home_dir }}/media_store"
 # The maximum allowed file size (in bytes) for media uploads to this homeserver
 # (0 = unlimited). If using a reverse proxy, ensure it allows requests at least
-#this large (e.g. the client_max_body_size setting in nginx).
+# this large (e.g. the client_max_body_size setting in nginx).
 dendrite_media_api_max_file_size_bytes: 10485760
 # Whether to dynamically generate thumbnails if needed.
 dendrite_media_api_dynamic_thumbnails: false

roles/dendrite/tasks/nginx.yml

@@ -26,7 +26,7 @@
   ansible.builtin.template:
     src: vhost.j2
     dest: /etc/nginx/sites-available/dendrite.conf
-    mode: 0644
+    mode: '0644'
   notify: Reload nginx
 
 - name: Enable Dendrite vhost

roles/dendrite/tasks/setup.yml

@@ -27,21 +27,21 @@
     path: "{{ dendrite_home_dir }}"
     owner: "{{ dendrite_service_user }}"
     group: "{{ dendrite_service_group }}"
-    mode: 0755
+    mode: '0755'
 
 - name: Make sure configuration directory exists
   ansible.builtin.file:
     path: '{{ dendrite_config_dir }}'
     state: directory
-    mode: 0750
+    mode: '0750'
     owner: "{{ dendrite_service_user }}"
     group: "{{ dendrite_service_group }}"
 
 - name: Make sure data directories exist
   ansible.builtin.file:
     path: '{{ dendrite_sync_api_search_index_path }}'
     state: directory
-    mode: 0775
+    mode: '0775'
     owner: "{{ dendrite_service_user }}"
     group: "{{ dendrite_service_group }}"
   loop:
@@ -94,7 +94,7 @@
   ansible.builtin.template:
     src: dendrite.yaml.j2
     dest: '{{ dendrite_config_file }}'
-    mode: 0640
+    mode: '0640'
     owner: "{{ dendrite_service_user }}"
     group: "{{ dendrite_service_group }}"
 
@@ -111,7 +111,7 @@
     dest: /etc/systemd/system/dendrite.service
     owner: root
     group: root
-    mode: 0644
+    mode: '0644'
   notify:
     - Reload systemd daemon
     - Restart dendrite

roles/diagnostic/tasks/setup_btop.yml

@@ -70,7 +70,7 @@
             - name: Create btop source directory
               ansible.builtin.file:
                 path: "{{ btop_source_path }}"
-                mode: "0775"
+                mode: '0775'
                 state: directory
 
             - name: Unpack the binary tarball version {{ btop_static_version }}

roles/diagnostic/tasks/setup_htop.yml

@@ -15,7 +15,7 @@
       ansible.builtin.copy:
         src: htoprc
         dest: "{{ '/root' if managing_user == 'root' else user_infos.home }}/.config/htop/"
-        mode: 0644
+        mode: '0644'
         owner: '{{ managing_user }}'
         group: "{{ 'root' if managing_user == 'root' else user_infos.group }}"
 

roles/drupal/tasks/instance.yml

@@ -115,7 +115,7 @@
     validate: 'php -l %s'
     owner: '{{ instance.drupal_user | default("root") }}'
     group: '{{ instance.drupal_group | default(nginx_group) }}'
-    mode: 0640
+    mode: '0640'
   when:
     - instance.write_settings_file is not defined or instance.write_settings_file
 
@@ -125,7 +125,7 @@
     dest: "{{ instance.dir }}/.env"
     owner: '{{ instance.drupal_user | default("root") }}'
     group: '{{ instance.drupal_group | default(nginx_group) }}'
-    mode: 0640
+    mode: '0640'
 
 - name: Check trusted TLS cert
   ansible.builtin.stat:
@@ -145,7 +145,7 @@
   ansible.builtin.template:
     src: etc/nginx/sites-available/drupal.j2
     dest: /etc/nginx/sites-available/{{ instance.name }}.conf
-    mode: 0644
+    mode: '0644'
   notify: Reload nginx
 
 - name: Ensure drupal vhosts is enabled - {{ instance.name }}
@@ -165,7 +165,7 @@
     password: '{{ item.password }}'
     owner: root
     group: '{{ nginx_group }}'
-    mode: 0640
+    mode: '0640'
   loop: '{{ instance.vhost_users | default([]) }}'
   when: instance.vhost_users is defined
   notify: Restart nginx

roles/drupal/tasks/instance_composer.yml

@@ -3,7 +3,7 @@
 - name: Make sure composer path exists - {{ instance.name }}
   ansible.builtin.file:
     path: '{{ instance.composer_path }}'
-    mode: 0755
+    mode: '0755'
     state: directory
   when: instance.composer_path is defined
 

roles/drupal/tasks/setup.yml

@@ -11,7 +11,7 @@
   ansible.builtin.template:
     src: etc/drush/aliases.drushrc.drupal.j2
     dest: /etc/drush/aliases.drushrc.drupal.php
-    mode: 0644
+    mode: '0644'
   when: >
     drupal_instances | length
     and (instance.state is undefined or instance.state == 'active')

roles/drush/tasks/setup.yml

@@ -28,19 +28,19 @@
   ansible.builtin.file:
     state: directory
     dest: /etc/drush
-    mode: 0755
+    mode: '0755'
 
 - name: Drush configuration update
   ansible.builtin.template:
     src: etc/drush/drushrc.j2
     dest: /etc/drush/drushrc.php
-    mode: 0644
+    mode: '0644'
 
 - name: Drush aliases configuration
   ansible.builtin.template:
     src: etc/drush/aliases.drushrc.php.j2
     dest: /etc/drush/aliases.drushrc.php
-    mode: 0644
+    mode: '0644'
 
 - name: Remove obsolete sync configuration
   ansible.builtin.file:
@@ -51,11 +51,11 @@
   ansible.builtin.template:
     src: reset.sh.j2
     dest: /usr/local/bin/reset_{{ drush_reset_script_name }}
-    mode: 0755
+    mode: '0755'
   when: drush_reset_script
 
 - name: Install sudoer access for zabbix
   ansible.builtin.template:
     src: etc/sudoers.d/drush.j2
     dest: /etc/sudoers.d/drush
-    mode: 0440
+    mode: '0440'

roles/element_web/tasks/nginx.yml

@@ -17,7 +17,7 @@
     password: '{{ item.password }}'
     owner: root
     group: '{{ nginx_group }}'
-    mode: 0640
+    mode: '0640'
   loop: '{{ element_web_vhost_users | default([]) }}'
   when:
     - element_web_vhost_users is defined
@@ -60,7 +60,7 @@
       ansible.builtin.template:
         src: vhost.j2
         dest: /etc/nginx/sites-available/element_web.conf
-        mode: 0644
+        mode: '0644'
       notify: Reload nginx
 
     - name: Enable element web vhost

roles/element_web/tasks/setup.yml

@@ -27,7 +27,7 @@
   ansible.builtin.template:
     src: config.json.j2
     dest: /etc/element-web/config.json
-    mode: 0644
+    mode: '0644'
     owner: root
     group: root
 

roles/ethercalc/tasks/nginx.yml

@@ -8,7 +8,7 @@
     password: '{{ item.password }}'
     owner: root
     group: '{{ nginx_group }}'
-    mode: 0640
+    mode: '0640'
   loop: '{{ ethercalc_vhost_users | default([]) }}'
   when:
     - ethercalc_vhost_users is defined
@@ -51,7 +51,7 @@
       ansible.builtin.template:
         src: vhost.j2
         dest: /etc/nginx/sites-available/ethercalc.conf
-        mode: 0644
+        mode: '0644'
       notify: Reload nginx
 
     - name: Enable ethercalc vhost

roles/ethercalc/tasks/setup.yml

@@ -36,7 +36,7 @@
     dest: /etc/systemd/system/ethercalc.service
     owner: root
     group: root
-    mode: 0644
+    mode: '0644'
   notify:
     - Reload systemd daemon
 

roles/fail2ban/tasks/messenger.yml

@@ -7,7 +7,7 @@
       ansible.builtin.template:
         src: messenger.conf.j2
         dest: '{{ fail2ban_action_path }}/rocketchat.conf'
-        mode: 0644
+        mode: '0644'
         owner: root
         group: root
       notify: Restart fail2ban
@@ -18,7 +18,7 @@
       ansible.builtin.template:
         src: messenger.sh.j2
         dest: '{{ fail2ban_action_path }}/rocketchat.sh'
-        mode: 0644
+        mode: '0644'
         owner: root
         group: root
       notify: Restart fail2ban