fix writable-strings warnings (pytorch#93246)

clang reports "ISO C++11 does not allow conversion from string
literal to 'char *'"

Pull Request resolved: pytorch#93246
Approved by: https://github.com/malfet

Author: cyyever

torch/csrc/StorageMethods.cpp

@@ -173,18 +173,16 @@ static PyObject* THPStorage_fromBuffer(
   PyObject* dtype_obj = nullptr;
   c10::ScalarType scalar_type = at::kByte;
   Py_buffer buffer = {};
-  // NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays,clang-diagnostic-writable-strings)
-  static char* kwlist[] = {
+  // NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays)
+  constexpr char* kwlist[] = {
       "buffer", "byte_order", "count", "offset", "dtype", nullptr};
-  // NOLINTNEXTLINE(cppcoreguidelines-init-variables)
-  const char* argtypes;
-  argtypes = "O|snnO";
+  constexpr char* argtypes = "O|snnO";
 
   if (!PyArg_ParseTupleAndKeywords(
           args,
           keywds,
           argtypes,
-          kwlist,
+          const_cast<char**>(kwlist),
           &obj,
           &byte_order_str,
           &count,
@@ -337,10 +335,16 @@ static PyObject* THPStorage_fromFile(
   const char* filename;
   Py_ssize_t nbytes = 0;
   int shared = 0;
-  // NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays,clang-diagnostic-writable-strings)
-  static char* kwlist[] = {"filename", "shared", "nbytes", nullptr};
+  // NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays)
+  constexpr char* kwlist[] = {"filename", "shared", "nbytes", nullptr};
   if (!PyArg_ParseTupleAndKeywords(
-          args, keywds, "s|in", kwlist, &filename, &shared, &nbytes)) {
+          args,
+          keywds,
+          "s|in",
+          const_cast<char**>(kwlist),
+          &filename,
+          &shared,
+          &nbytes)) {
     return nullptr;
   }
   if (shared)

torch/csrc/Stream.cpp

@@ -16,13 +16,14 @@ static PyObject* THPStream_pynew(
   int64_t stream_id = 0;
   int64_t device_index = 0;
   int64_t device_type = 0;
-  // NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays,clang-diagnostic-writable-strings)
-  static char* kwlist[] = {"stream_id", "device_index", "device_type", nullptr};
+  // NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays)
+  constexpr char* kwlist[] = {
+      "stream_id", "device_index", "device_type", nullptr};
   if (!PyArg_ParseTupleAndKeywords(
           args,
           kwargs,
           "|LLL",
-          kwlist,
+          const_cast<char**>(kwlist),
           &stream_id,
           &device_index,
           &device_type)) {

torch/csrc/autograd/python_anomaly_mode.h

@@ -10,9 +10,7 @@ namespace torch {
 namespace autograd {
 
 struct PyAnomalyMetadata : public AnomalyMetadata {
-  // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables,clang-diagnostic-writable-strings)
   static constexpr const char* ANOMALY_TRACE_KEY = "traceback_";
-  // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables,clang-diagnostic-writable-strings)
   static constexpr const char* ANOMALY_PARENT_KEY = "parent_";
 
   PyAnomalyMetadata() {

torch/csrc/autograd/python_engine.cpp

@@ -179,20 +179,20 @@ PyObject* THPEngine_run_backward(
   unsigned char allow_unreachable = 0;
   unsigned char accumulate_grad =
       0; // Indicate whether to accumulate grad into leaf Tensors or capture
-  const char* accepted_kwargs[] = {// NOLINT
-                                   "tensors",
-                                   "grad_tensors",
-                                   "keep_graph",
-                                   "create_graph",
-                                   "inputs",
-                                   "allow_unreachable",
-                                   "accumulate_grad",
-                                   nullptr};
+  constexpr char* accepted_kwargs[] = {// NOLINT
+                                       "tensors",
+                                       "grad_tensors",
+                                       "keep_graph",
+                                       "create_graph",
+                                       "inputs",
+                                       "allow_unreachable",
+                                       "accumulate_grad",
+                                       nullptr};
   if (!PyArg_ParseTupleAndKeywords(
           args,
           kwargs,
           "OObb|Obb",
-          (char**)accepted_kwargs,
+          const_cast<char**>(accepted_kwargs),
           &tensors,
           &grad_tensors,
           &keep_graph,

torch/csrc/autograd/python_legacy_variable.cpp

@@ -26,13 +26,13 @@ static PyObject* THPVariable_pynew(
   const char* name = nullptr;
 
   // NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays)
-  const char* accepted_args[] = {
+  constexpr char* accepted_args[] = {
       "data", "requires_grad", "volatile", "_grad_fn", "name", nullptr};
   if (!PyArg_ParseTupleAndKeywords(
           args,
           kwds,
           "|ObbOz",
-          (char**)accepted_args,
+          const_cast<char**>(accepted_args),
           &data,
           &requires_grad,
           &is_volatile,

torch/csrc/cuda/Event.cpp

@@ -25,13 +25,13 @@ static PyObject* THCPEvent_pynew(
   unsigned char interprocess = 0;
 
   // NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays)
-  static char* kwlist[] = {
+  constexpr char* kwlist[] = {
       "enable_timing", "blocking", "interprocess", nullptr};
   if (!PyArg_ParseTupleAndKeywords(
           args,
           kwargs,
           "|bbb",
-          kwlist,
+          const_cast<char**>(kwlist),
           &enable_timing,
           &blocking,
           &interprocess)) {

torch/csrc/cuda/Module.cpp

@@ -230,12 +230,13 @@ PyObject* THCPModule_setStream_wrap(
   int64_t device_type = 0;
 
   // NOLINTNEXTLINE(modernize-avoid-c-arrays,cppcoreguidelines-avoid-c-arrays)
-  static char* kwlist[] = {"stream_id", "device_index", "device_type", nullptr};
+  constexpr char* kwlist[] = {
+      "stream_id", "device_index", "device_type", nullptr};
   if (!PyArg_ParseTupleAndKeywords(
           args,
           kwargs,
           "|LLL",
-          kwlist,
+          const_cast<char**>(kwlist),
           &stream_id,
           &device_index,
           &device_type)) {

torch/csrc/cuda/Stream.cpp

@@ -28,7 +28,7 @@ static PyObject* THCPStream_pynew(
   uint64_t stream_ptr = 0;
 
   // NOLINTNEXTLINE(modernize-avoid-c-arrays,cppcoreguidelines-avoid-c-arrays)
-  static char* kwlist[] = {
+  constexpr char* kwlist[] = {
       "priority",
       "stream_id",
       "device_index",
@@ -39,7 +39,7 @@ static PyObject* THCPStream_pynew(
           args,
           kwargs,
           "|iLLLK",
-          kwlist,
+          const_cast<char**>(kwlist),
           &priority,
           &stream_id,
           &device_index,

torch/csrc/utils/disable_torch_function.cpp

@@ -297,7 +297,6 @@ static bool is_basic_python_type(PyTypeObject* tp) {
 }
 
 inline bool has_torch_function_attr(PyObject* obj) {
-  // NOLINTNEXTLINE(clang-diagnostic-writable-strings)
   auto attr = PyObject_FastGetAttrString(obj, "__torch_function__");
   return (
       attr.ptr() != nullptr && attr.ptr() != torch::disabled_torch_function);

torch/csrc/utils/python_arg_parser.cpp

@@ -350,7 +350,6 @@ auto handle_torch_function_no_python_arg_parser(
   }
   if (ret.ptr() == nullptr || ret.ptr() == Py_NotImplemented) {
     for (auto& arg : overloaded_args) {
-      // NOLINTNEXTLINE(clang-diagnostic-writable-strings)
       py::object torch_function =
           PyObject_FastGetAttrString(arg.ptr(), torch_function_name_str);
       if (!torch_function) {