Skip to content

unit tests for CholeskyFactorizer #206

unit tests for CholeskyFactorizer

unit tests for CholeskyFactorizer #206

Triggered via push March 10, 2026 13:29
Status Success
Total duration 12s
Artifacts

dox.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

41 warnings
doc list item overindented: src/lipschitz_estimator.rs#L83
warning: doc list item overindented --> src/lipschitz_estimator.rs:83:9 | 83 | /// value of the given function at `u_`, that is `f_(u_)` | ^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/lipschitz_estimator.rs#L80
warning: doc list item overindented --> src/lipschitz_estimator.rs:80:9 | 80 | /// before you provide it to this method. | ^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/lipschitz_estimator.rs#L79
warning: doc list item overindented --> src/lipschitz_estimator.rs:79:9 | 79 | /// to keep the original value of `u_`, you need to make a copy of the variable | ^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/lipschitz_estimator.rs#L78
warning: doc list item overindented --> src/lipschitz_estimator.rs:78:9 | 78 | /// reference). The value of `u_` at exit is slightly perturbed. If you need | ^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/lipschitz_estimator.rs#L77
warning: doc list item overindented --> src/lipschitz_estimator.rs:77:9 | 77 | /// On exit: the provided slice is modified (this is why it is a mutable | ^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/core/solver_status.rs#L35
warning: doc list item overindented --> src/core/solver_status.rs:35:9 | 35 | /// quality | ^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item without indentation: src/core/panoc/panoc_cache.rs#L161
warning: doc list item without indentation --> src/core/panoc/panoc_cache.rs:161:9 | 161 | /// are satisfied. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 161 | /// are satisfied. | +++
usage of a legacy numeric constant: src/core/panoc/panoc_cache.rs#L75
warning: usage of a legacy numeric constant --> src/core/panoc/panoc_cache.rs:75:29 | 75 | norm_gamma_fpr: std::f64::INFINITY, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#legacy_numeric_constants help: use the associated constant instead | 75 - norm_gamma_fpr: std::f64::INFINITY, 75 + norm_gamma_fpr: f64::INFINITY, |
usage of a legacy numeric constant: src/core/fbs/fbs_cache.rs#L46
warning: usage of a legacy numeric constant --> src/core/fbs/fbs_cache.rs:46:23 | 46 | norm_fpr: std::f64::INFINITY, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#legacy_numeric_constants help: use the associated constant instead | 46 - norm_fpr: std::f64::INFINITY, 46 + norm_fpr: f64::INFINITY, |
doc list item overindented: src/constraints/hyperplane.rs#L72
warning: doc list item overindented --> src/constraints/hyperplane.rs:72:9 | 72 | /// (out) projection on the second-order cone | ^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/constraints/halfspace.rs#L75
warning: doc list item overindented --> src/constraints/halfspace.rs:75:9 | 75 | /// (out) projection on the second-order cone | ^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
manual implementation of `.is_multiple_of()`: src/constraints/affine_space.rs#L34
warning: manual implementation of `.is_multiple_of()` --> src/constraints/affine_space.rs:34:13 | 34 | n_elements_a % n_rows == 0, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `n_elements_a.is_multiple_of(n_rows)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#manual_is_multiple_of = note: `#[warn(clippy::manual_is_multiple_of)]` on by default
the loop variable `j` is used to index `x`: src/cholesky_factorizer.rs#L98
warning: the loop variable `j` is used to index `x` --> src/cholesky_factorizer.rs:98:22 | 98 | for j in (i + 1)..n { | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_range_loop help: consider using an iterator and enumerate() | 98 - for j in (i + 1)..n { 98 + for (j, <item>) in x.iter().enumerate().take(n).skip((i + 1)) { |
the loop variable `j` is used to index `y`: src/cholesky_factorizer.rs#L88
warning: the loop variable `j` is used to index `y` --> src/cholesky_factorizer.rs:88:22 | 88 | for j in 0..i { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator and enumerate() | 88 - for j in 0..i { 88 + for (j, <item>) in y.iter().enumerate().take(i) { |
the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable: src/cholesky_factorizer.rs#L51
warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable --> src/cholesky_factorizer.rs:51:24 | 51 | if !(sum > T::zero()) { | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#neg_cmp_op_on_partial_ord = note: `#[warn(clippy::neg_cmp_op_on_partial_ord)]` on by default
this function has too many arguments (9/7): src/alm/alm_problem.rs#L135
warning: this function has too many arguments (9/7) --> src/alm/alm_problem.rs:135:5 | 135 | / pub fn new( 136 | | constraints: ConstraintsType, 137 | | alm_set_c: Option<AlmSetC>, 138 | | alm_set_y: Option<LagrangeSetY>, ... | 144 | | n2: usize, 145 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#too_many_arguments
doc list item overindented: src/alm/alm_problem.rs#L106
warning: doc list item overindented --> src/alm/alm_problem.rs:106:8 | 106 | /// compact subset of $C^*$ (the convex conjugate of the convex set $C{}\subseteq{}\mathbb{R}^{n_1}$) | ^^^^ help: try using ` ` (3 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/alm/alm_optimizer_status.rs#L125
warning: doc list item overindented --> src/alm/alm_optimizer_status.rs:125:9 | 125 | /// into an internal field of `AlmOptimizerStatus`) | ^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
empty doc comment: src/alm/alm_optimizer_status.rs#L22
warning: empty doc comment --> src/alm/alm_optimizer_status.rs:22:5 | 22 | /// | ^^^ | = help: consider removing or filling it = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#empty_docs = note: `#[warn(clippy::empty_docs)]` on by default
usage of a legacy numeric constant: src/alm/alm_optimizer.rs#L735
warning: usage of a legacy numeric constant --> src/alm/alm_optimizer.rs:735:71 | 735 | .unwrap_or_else(|| std::time::Duration::from_secs(std::u64::MAX)), | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#legacy_numeric_constants help: use the associated constant instead | 735 - .unwrap_or_else(|| std::time::Duration::from_secs(std::u64::MAX)), 735 + .unwrap_or_else(|| std::time::Duration::from_secs(u64::MAX)), |
doc list item overindented: src/alm/alm_optimizer.rs#L533
warning: doc list item overindented --> src/alm/alm_optimizer.rs:533:9 | 533 | /// length equal to `n1` | ^^^^^^^^^^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/alm/alm_optimizer.rs#L470
warning: doc list item overindented --> src/alm/alm_optimizer.rs:470:9 | 470 | /// the value $\espilon_0$ | ^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/alm/alm_optimizer.rs#L210
warning: doc list item overindented --> src/alm/alm_optimizer.rs:210:8 | 210 | /// $\nabla_u \psi(u, \xi)$, $F_1(u)$ (if any), $F_2(u)$ (if any), and sets | ^^^^ help: try using ` ` (3 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/alm/alm_optimizer.rs#L208
warning: doc list item overindented --> src/alm/alm_optimizer.rs:208:8 | 208 | /// `AlmOptimizer` | ^^^^ help: try using ` ` (3 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/alm/alm_optimizer.rs#L85
warning: doc list item overindented --> src/alm/alm_optimizer.rs:85:5 | 85 | /// (see [`AlmFactory`](./struct.AlmFactory.html) regarding how this is constructed) | ^^^^^^^^ help: try using ` ` (6 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/alm/alm_optimizer.rs#L84
warning: doc list item overindented --> src/alm/alm_optimizer.rs:84:5 | 84 | /// solved with tolerance $\bar\epsilon$ | ^^^^^^^^ help: try using ` ` (6 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
usage of a legacy numeric constant: src/alm/alm_optimizer.rs#L16
warning: usage of a legacy numeric constant --> src/alm/alm_optimizer.rs:16:28 | 16 | const SMALL_EPSILON: f64 = std::f64::EPSILON; | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#legacy_numeric_constants help: use the associated constant instead | 16 - const SMALL_EPSILON: f64 = std::f64::EPSILON; 16 + const SMALL_EPSILON: f64 = f64::EPSILON; |
this function has too many arguments (8/7): src/alm/alm_factory.rs#L158
warning: this function has too many arguments (8/7) --> src/alm/alm_factory.rs:158:5 | 158 | / pub fn new( 159 | | f: Cost, 160 | | df: CostGradient, 161 | | mapping_f1: Option<MappingF1>, ... | 166 | | n2: usize, 167 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
doc list item overindented: src/alm/alm_factory.rs#L46
warning: doc list item overindented --> src/alm/alm_factory.rs:46:4 | 46 | /// of the constraints $F_1(u) \in C$ | ^^^^^^^^^^^ help: try using ` ` (3 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/alm/alm_factory.rs#L43
warning: doc list item overindented --> src/alm/alm_factory.rs:43:4 | 43 | /// $u\in\mathbb{R}^{n_u}$ | ^^^^ help: try using ` ` (3 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/alm/alm_factory.rs#L42
warning: doc list item overindented --> src/alm/alm_factory.rs:42:4 | 42 | /// product of the form $JF_i(u)^\top{}d$ for given $d\in\mathbb{R}^{n_i}$ and | ^^^^ help: try using ` ` (3 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/alm/alm_factory.rs#L35
warning: doc list item overindented --> src/alm/alm_factory.rs:35:4 | 35 | /// are computed by functions with signature | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using ` ` (3 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/alm/alm_factory.rs#L34
warning: doc list item overindented --> src/alm/alm_factory.rs:34:4 | 34 | /// and $F_2:\mathbb{R}^n\to\mathbb{R}^{n_2}$ which | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using ` ` (3 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/alm/alm_factory.rs#L25
warning: doc list item overindented --> src/alm/alm_factory.rs:25:4 | 25 | /// which is computed by a function with signature | ^^^^^^^^^^^^^^^^^^^ help: try using ` ` (3 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
doc list item overindented: src/alm/alm_factory.rs#L16
warning: doc list item overindented --> src/alm/alm_factory.rs:16:4 | 16 | /// by a function with signature: | ^^^^^^^^^^^ help: try using ` ` (3 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items
usage of a legacy numeric constant: src/alm/alm_cache.rs#L82
warning: usage of a legacy numeric constant --> src/alm/alm_cache.rs:82:27 | 82 | f2_norm_plus: std::f64::INFINITY, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#legacy_numeric_constants help: use the associated constant instead | 82 - f2_norm_plus: std::f64::INFINITY, 82 + f2_norm_plus: f64::INFINITY, |
usage of a legacy numeric constant: src/alm/alm_cache.rs#L80
warning: usage of a legacy numeric constant --> src/alm/alm_cache.rs:80:32 | 80 | delta_y_norm_plus: std::f64::INFINITY, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 80 - delta_y_norm_plus: std::f64::INFINITY, 80 + delta_y_norm_plus: f64::INFINITY, |
doc list item overindented: src/alm/alm_cache.rs#L54
warning: doc list item overindented --> src/alm/alm_cache.rs:54:9 | 54 | /// the inner problem | ^^^ help: try using ` ` (2 spaces) | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#doc_overindented_list_items = note: `#[warn(clippy::doc_overindented_list_items)]` on by default
fields `a_mat`, `b_vec`, `l`, `n_rows`, and `n_cols` are never read: src/constraints/affine_space.rs#L10
warning: fields `a_mat`, `b_vec`, `l`, `n_rows`, and `n_cols` are never read --> src/constraints/affine_space.rs:10:5 | 9 | pub struct AffineSpace { | ----------- fields in this struct 10 | a_mat: Vec<f64>, | ^^^^^ 11 | b_vec: Vec<f64>, | ^^^^^ 12 | l: Vec<f64>, | ^ 13 | n_rows: usize, | ^^^^^^ 14 | n_cols: usize, | ^^^^^^ | = note: `AffineSpace` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
unused import: `super::Constraint`: src/constraints/affine_space.rs#L1
warning: unused import: `super::Constraint` --> src/constraints/affine_space.rs:1:5 | 1 | use super::Constraint; | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
empty line after outer attribute: src/cholesky_factorizer.rs#L63
warning: empty line after outer attribute --> src/cholesky_factorizer.rs:63:5 | 63 | / #[inline] 64 | | | |_^ 65 | /// dim 66 | pub fn dimension(&self) -> usize { | ---------------- the attribute applies to this function | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#empty_line_after_outer_attr = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default = help: if the empty line is unintentional, remove it