-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Description
splash_auth/splash_auth/main.py
Line 34 in 207d643
| <script src="https://code.jquery.com/jquery-2.2.4.js"></script> |
A minor optimization, but it reduces the number of moving parts.
There is no jQuery, or even Javascript, needed for this operation. The Python code that uses this string ( https://github.com/als-computing/splash_auth/blob/207d6430bb30bc61f4c4c03c7e9b539fe93993a7/splash_auth/main.py#L88C12-L88C21 ) is using .format to swap in variables, so we can just swap them directly into the href of the element in the document, rather than attaching an href to it using jQuery's "ready" event. ... which I assume we are only using in order to wait for jQuery to load (Catch-22!).
Metadata
Metadata
Assignees
Labels
No labels