Enabling pytorch-kernels on Windows#348
Merged
Merged
Conversation
…n Linux extension tests
…io 2022 or newer on Windows
sdevinenamd
reviewed
Jun 7, 2026
Co-authored-by: Satya Devineni <satya.devineni@amd.com>
Collaborator
Author
|
Can you please review the updated |
sdevinenamd
approved these changes
Jun 8, 2026
sdevinenamd
left a comment
Collaborator
There was a problem hiding this comment.
One suggestion: The activating VS C++ dependencies part looks cluttered, would be good if we can split it into sub blocks. Rest all looks good.
…pproach B: C++ Extension
Collaborator
Author
Visual Studio C++ env activation split into sub-blocks as you suggested. Thank you for the detailed review, @sdevinenamd!! |
danielholanda
approved these changes
Jun 8, 2026
danielholanda
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good.
Trusting @sdevinenamd 's review here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platform.mdrocm.mdwith@testblockssudo apt -y install build-essential gcc g++python -m pip install "setuptools<82" wheel ninjaninjamakes PyTorch extension builds faster and closer to the prefereed PyTorch build path.setuptools<82avoids known dependency mismatch.torch 2.11.0+rocm7.13.0 requires setuptools<82