Skip to content

Enabling pytorch-kernels on Windows#348

Merged
sreeram-11 merged 17 commits into
mainfrom
sreeram/pytorch-kernels-windows-support
Jun 9, 2026
Merged

Enabling pytorch-kernels on Windows#348
sreeram-11 merged 17 commits into
mainfrom
sreeram/pytorch-kernels-windows-support

Conversation

@sreeram-11

@sreeram-11 sreeram-11 commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator
  1. Enabled Windows support
  2. Extended support to STX/KRK
  3. Updated platform.md
  4. Updated rocm.md with @test blocks
  5. [Linux]: Added user instructions to install the Linux C/C++ build toolchain
    • sudo apt -y install build-essential gcc g++
  6. [Windows]: User instructions and tests updated to support Visual Studio 2022 or newer
  7. Updated the additional dependencies command to python -m pip install "setuptools<82" wheel ninja
    • ninja makes PyTorch extension builds faster and closer to the prefereed PyTorch build path.
    • setuptools<82 avoids known dependency mismatch. torch 2.11.0+rocm7.13.0 requires setuptools<82

Comment thread playbooks/supplemental/pytorch-kernels/README.md
Comment thread playbooks/supplemental/pytorch-kernels/README.md Outdated
Comment thread playbooks/supplemental/pytorch-kernels/README.md Outdated
Comment thread playbooks/supplemental/pytorch-kernels/README.md
Comment thread playbooks/supplemental/pytorch-kernels/README.md
sreeram-11 and others added 2 commits June 7, 2026 23:36
Co-authored-by: Satya Devineni <satya.devineni@amd.com>
@sreeram-11

Copy link
Copy Markdown
Collaborator Author

@sdevinenamd,

Can you please review the updated platform.md?

@sdevinenamd sdevinenamd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion: The activating VS C++ dependencies part looks cluttered, would be good if we can split it into sub blocks. Rest all looks good.

@sreeram-11

Copy link
Copy Markdown
Collaborator Author

One suggestion: The activating VS C++ dependencies part looks cluttered, would be good if we can split it into sub blocks. Rest all looks good.

Visual Studio C++ env activation split into sub-blocks as you suggested.

Thank you for the detailed review, @sdevinenamd!!

@danielholanda danielholanda left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
Trusting @sdevinenamd 's review here.

@sreeram-11 sreeram-11 merged commit 981dc35 into main Jun 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants