Throws TimeoutException when TransferTimeout is exceeded #382
+51
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luzrain
force-pushed
the
transfer_timeout_exception
branch
from
6cc11c8 to
57cce05
Compare
|
Here is the code to reproduce the issue. <?php
use Amp\Http\Client\HttpClientBuilder;
use Amp\Http\Client\Request;
require dirname(__DIR__, 1) . '/vendor/autoload.php';
$client = (new HttpClientBuilder())->retry(0)->build();
$request = new Request('https://httpbin.org/delay/5');
$request->setTransferTimeout(1);
try {
$request1 = clone $request;
$request1->setProtocolVersions(['1.1']);
$response = $client->request($request1);
} catch (\Throwable $e) {
var_dump('HTTP/1.1 ' . $e::class . ': ' . $e->getMessage());
}
try {
$request2 = clone $request;
$request2->setProtocolVersions(['2']);
$response = $client->request($request2);
} catch (\Throwable $e) {
var_dump('HTTP/2 ' . $e::class . ': ' . $e->getMessage());
}The output without the fix: With this fix: |
|
LGTM on first sight, but only looked on mobile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that when setting a TransferTimeout limit on a request, the thrown exception is a
SocketExceptioninstead of aTimeoutException. This issue only affects HTTP connections, HTTP/2 connections correctly throwTimeoutExceptionin such cases as expected.This change makes the code throw a
TimeoutExceptioninstead of aSocketExceptionwhen a connection session exceeds the TransferTimeout period.Closes #379