Immediately invoke onInit callbacks if amplitude is already initialized (#179)

Author: blazzy

src/amplitude-client.js

@@ -40,6 +40,7 @@ var AmplitudeClient = function AmplitudeClient(instanceName) {
   this._newSession = false;
   this._sequenceNumber = 0;
   this._sessionId = null;
+  this._isInitialized = false;
 
   this._userAgent = (navigator && navigator.userAgent) || null;
 };
@@ -155,6 +156,7 @@ AmplitudeClient.prototype.init = function init(apiKey, opt_userId, opt_config, o
     this._onInit[i]();
   }
   this._onInit = [];
+  this._isInitialized = true;
 };
 
 /**
@@ -296,7 +298,11 @@ AmplitudeClient.prototype.isNewSession = function isNewSession() {
  * @private
  */
 AmplitudeClient.prototype.onInit = function (callback) {
-  this._onInit.push(callback);
+  if (this._isInitialized) {
+    callback();
+  } else {
+    this._onInit.push(callback);
+  }
 };
 
 /**

test/amplitude-client.js

@@ -65,6 +65,22 @@ describe('AmplitudeClient', function() {
       assert.ok(onInit2Called);
     });
 
+    it('should not invoke onInit callbacks before init is called', function() {
+      let onInitCalled = false;
+      amplitude.onInit(() => { onInitCalled = true; });
+
+      assert.ok(onInitCalled === false);
+      amplitude.init(apiKey);
+      assert.ok(onInitCalled);
+    });
+
+    it('should immediately invoke onInit callbacks if already initialized', function() {
+      let onInitCalled = false;
+      amplitude.init(apiKey);
+      amplitude.onInit(() => { onInitCalled = true; });
+      assert.ok(onInitCalled);
+    });
+
     it('should clear the onInitQueue', function() {
       let onInitCalled = false;
       let onInit2Called = false;