Fix bug preventing logLevel from being set to disabled (#169)

Author: blazzy

amplitude.js

@@ -2062,7 +2062,9 @@ var logLevels = {
 var logLevel = logLevels.WARN;
 
 var setLogLevel = function setLogLevel(logLevelName) {
-  logLevel = logLevels[logLevelName] || logLevel;
+  if (logLevels.hasOwnProperty(logLevelName)) {
+    logLevel = logLevels[logLevelName];
+  }
 };
 
 var getLogLevel = function getLogLevel() {
@@ -2284,6 +2286,7 @@ var getQueryParam = function getQueryParam(name, query) {
 var utils = {
   setLogLevel: setLogLevel,
   getLogLevel: getLogLevel,
+  logLevels: logLevels,
   log: log,
   isEmptyString: isEmptyString,
   getQueryParam: getQueryParam,

amplitude.min.js

@@ -11,7 +11,9 @@ var logLevels = {
 let logLevel = logLevels.WARN;
 
 const setLogLevel = function setLogLevel(logLevelName) {
-  logLevel = logLevels[logLevelName] || logLevel;
+  if (logLevels.hasOwnProperty(logLevelName)) {
+    logLevel = logLevels[logLevelName];
+  }
 };
 
 const getLogLevel = function getLogLevel() {
@@ -236,6 +238,7 @@ var getQueryParam = function getQueryParam(name, query) {
 export default {
   setLogLevel,
   getLogLevel,
+  logLevels,
   log,
   isEmptyString,
   getQueryParam,

src/utils.js

@@ -14,6 +14,33 @@ describe('utils', function() {
     });
   });
 
+  describe('setLogLevel', function() {
+    afterEach(() => {
+      utils.setLogLevel('WARN');
+    });
+
+    it('can set log level to DISABLE', function() {
+      utils.setLogLevel('DISABLE');
+      assert.strictEqual(utils.getLogLevel(), utils.logLevels.DISABLE);
+    });
+
+    it('can set log level to ERROR', () => {
+      utils.setLogLevel('ERROR');
+      assert.strictEqual(utils.getLogLevel(), utils.logLevels.ERROR);
+    });
+
+    it('can set log level to WARN', () => {
+      utils.setLogLevel('DISABLE');
+      utils.setLogLevel('WARN');
+      assert.strictEqual(utils.getLogLevel(), utils.logLevels.WARN);
+    });
+
+    it('can set log level to INFO', () => {
+      utils.setLogLevel('INFO');
+      assert.strictEqual(utils.getLogLevel(), utils.logLevels.INFO);
+    });
+  });
+
   describe('log', function() {
     beforeEach(function() {
       utils.setLogLevel('INFO');