Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context-keyword notify feature #841

Open
jridgewell opened this issue May 6, 2020 · 1 comment
Open

Add context-keyword notify feature #841

jridgewell opened this issue May 6, 2020 · 1 comment

Comments

@jridgewell
Copy link
Contributor

Context: ampproject/amphtml#28203

When an extension adds prerenderAllowed to a JS file, it then requires approval by Runtime team. It'd be nice if we could add a context-keyword setting to the notify settings, so that this is done automatically.

@rcebulko
Copy link
Contributor

While I can see how this would definitely be a useful feature, it doesn't seem to have a close tie-in with most of the owners bot functionality. Are there many other cases like this where particular tokens require team approval, or is it more typically a set of runtime-related keywords? I ask because my hunch is that this may be better solved with a dedicated app to scan each PR and block where relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants