Change some custom nodes to be regular AstNodes #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, the entire jeff65.gold.storage module is gone, along with jeff65.gold.passes.asm.AsmRun. As an additional advantage, some compiler passes which were previously imperative are now pattern-based. (This was rescued from PR #37 asm-blocks, where it was mixed in with a bunch of other changes.)
Pull Request Test Coverage Report for Build 273
💛 - Coveralls |
|
I feel slightly guilty about the slight reduction in test coverage, but it's honestly due to the fact that I deleted some code that was covered, and the four relevant uncovered lines are related to lowering, which is probably about to get rewritten as I pull things into backends. SO I'M LETTING IT STAND |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, the entire jeff65.gold.storage module is gone, along with
jeff65.gold.passes.asm.AsmRun. As an additional advantage, some compiler
passes which were previously imperative are now pattern-based.
(This was rescued from PR #37 asm-blocks, where it was mixed in with a
bunch of other changes.)