Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugs #1

Open
soumith opened this issue Nov 24, 2014 · 6 comments
Open

bugs #1

soumith opened this issue Nov 24, 2014 · 6 comments

Comments

@soumith
Copy link

soumith commented Nov 24, 2014

should be sum, not max: https://github.com/andresy/torch9/blob/master/maths.lua#L124

badlogic - https://github.com/andresy/torch9/blob/master/tensor.lua#L359

@andresy
Copy link
Owner

andresy commented Nov 24, 2014

yep for the max->sum
why do you say badlogic?

@soumith
Copy link
Author

soumith commented Nov 24, 2014

elseif src.__nDimension == 1 and src.__size[0] == 1 then
return src:data()[0]
...

I am keeping this issue for tracking bugs, you dont need to do anything for now.

@andresy
Copy link
Owner

andresy commented Nov 24, 2014

oh, yes, thanks :)

@soumith
Copy link
Author

soumith commented Nov 24, 2014

ztorch will be fully unit-tested, i am trying my best, so i will find the bugs from there and report back here.

@andresy
Copy link
Owner

andresy commented Nov 24, 2014

cool

@soumith
Copy link
Author

soumith commented Nov 24, 2014

#badlogic - https://github.com/andresy/torch9/blob/master/maths.lua#L155 you never pass res to cadd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants