Skip to content

Commit 47d6fa6

Browse files
toniheicopybara-github
authored andcommitted
Make getSecondaryRenderer non-default
The ExoPlayer interface is not generally implemented and there is no need for default methods. PiperOrigin-RevId: 817661255
1 parent 82ee103 commit 47d6fa6

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayer.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1355,9 +1355,7 @@ public ExoPlayer build() {
13551355
*/
13561356
@UnstableApi
13571357
@Nullable
1358-
default Renderer getSecondaryRenderer(int index) {
1359-
return null;
1360-
}
1358+
Renderer getSecondaryRenderer(int index);
13611359

13621360
/**
13631361
* Returns the track selector that this player uses, or null if track selection is not supported.

libraries/exoplayer/src/main/java/androidx/media3/exoplayer/SimpleExoPlayer.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,6 +1106,12 @@ public Renderer getRenderer(int index) {
11061106
return player.getRenderer(index);
11071107
}
11081108

1109+
@Override
1110+
public Renderer getSecondaryRenderer(int index) {
1111+
blockUntilConstructorFinished();
1112+
return player.getSecondaryRenderer(index);
1113+
}
1114+
11091115
@Override
11101116
public TrackSelector getTrackSelector() {
11111117
blockUntilConstructorFinished();

libraries/test_utils/src/main/java/androidx/media3/test/utils/StubExoPlayer.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,11 @@ public Renderer getRenderer(int index) {
316316
throw new UnsupportedOperationException();
317317
}
318318

319+
@Override
320+
public Renderer getSecondaryRenderer(int index) {
321+
throw new UnsupportedOperationException();
322+
}
323+
319324
@Override
320325
@Nullable
321326
public TrackSelector getTrackSelector() {

0 commit comments

Comments
 (0)