Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix slider jumps to first value if value is not in stepsArray #29

Closed
dexbytesmanish opened this issue Oct 19, 2018 · 5 comments
Closed

Comments

@dexbytesmanish
Copy link

Hi,
is this below mentioned issue also fixed in Angular 5 version of slider ?
angular-slider/angularjs-slider#626

Please confirm or fix that also in this version.

piotrdz added a commit that referenced this issue Oct 23, 2018
New behaviour is to jump to first nearest value instead
@piotrdz
Copy link
Member

piotrdz commented Oct 23, 2018

The merge request in question hasn't been merged to angularjs-slider, so the issue was also present when I rewrote the code to Angular 5.

I fixed the problem presently with my own implementation. The slider will now jump to the first closest value.

@dexbytesmanish
Copy link
Author

ok, thanks. Can you please also check and confirm that all other issues that were reported for angularjs-slider have been fixed for Angular 5 too regardless of their status in angularjs-slider repo ?

@piotrdz
Copy link
Member

piotrdz commented Oct 24, 2018

Well, when I originally forked the project, I rewrote it as-is, without looking at angularjs issues or pull requests. The goal was mainly to have the component working in Angular 5.

You raise a good point about going back to these issues in angularjs project, but forgive me for saying so, the way you are asking this is not very polite. Please understand that this is an open-source project that I maintain in my own spare time and I'm not paid to do so.

Now, I'll probably go through these issues eventually, but I can't give you a timeframe for this. I'm quite busy with other things at the moment. In the meantime, I'm happy to fix some specific issues that people are having trouble with, as well as accepting any pull requests.

@piotrdz
Copy link
Member

piotrdz commented Oct 24, 2018

Closing as originally reported issue fixed with v1.1.4 ( StackBlitz example ).

@piotrdz piotrdz closed this as completed Oct 24, 2018
@dexbytesmanish
Copy link
Author

There is still one more issue remaing in this case. Slider is jumping to first closes value but that value is not being updated to model bindings hence model binded values are not showing updated values as the slider is actually having. Please check this ( [StackBlitz Example]) (https://stackblitz.com/edit/ng5-slider-issue-29-vh9erz) for the remaining issue.

jeanfsantos pushed a commit to jeanfsantos/ngx-slider that referenced this issue Jun 28, 2023
…slider#29)

New behaviour is to jump to first nearest value instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants