Skip to content

Commit 5e02f8a

Browse files
committed
fix: infinity loop when parent and injectedParent are the same
1 parent 6f31035 commit 5e02f8a

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

libs/angular-three/src/lib/renderer/renderer.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,11 @@ export class NgtRenderer implements Renderer2 {
168168
if (cRS[NgtRendererClassId.injectedParent]) {
169169
if (is.ref(cRS[NgtRendererClassId.injectedParent])) {
170170
cRS[NgtRendererClassId.injectedParent].$.pipe(take(1)).subscribe((val) => {
171-
this.appendChild(val, newChild);
171+
if (val !== parent) {
172+
this.appendChild(val, newChild);
173+
}
172174
});
173-
} else {
175+
} else if (parent !== cRS[NgtRendererClassId.injectedParent]) {
174176
this.appendChild(cRS[NgtRendererClassId.injectedParent], newChild);
175177
}
176178
return;

0 commit comments

Comments
 (0)