Skip to content

Invalid arguments provided in click handler of selectionSelectAllButtons & treeBaseExpandAllButtons #4551

Open
@Maus3rVonDutch

Description

@Maus3rVonDutch

Hi,

there is a bug in the ui-grid/selectionSelectAllButtons template or its directive: the click handler in directive uiGridSelectionSelectAllButtons is expecting 2 arguments:

$scope.headerButtonClick = function(row, evt) { }

but only the $event argument is provided, resulting in a wrongly assigned argument (i.e. event is passed as the row argument). You should either fix the template or modify the directive. The same goes for the uiGridTreeBaseExpandAllButtons directive btw.

NB I suggest you modify the templates to

ng-click="headerButtonClick(null, $event)"

because then you keep your code in line with the other templates (e.g. selectionRowHeaderButtons.html)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions