This repository was archived by the owner on Oct 2, 2019. It is now read-only.
This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Multiple mode: Search text is not cleared on tab out #367
Open
Activity
YidingW commentedon Nov 17, 2014
+1
cgwyllie commentedon Nov 18, 2014
+1 I saw this issue too, but I'm not sure if it's a bug or just a strange/non-obvious default.
I was able to resolve this by using the
reset-search-input="true"
attribute on the<ui-select/>
. Reference: https://github.com/angular-ui/ui-select/wiki/ui-select#attributesamcdnl commentedon Nov 19, 2014
@afcastano does that solve your problem?
YidingW commentedon Nov 19, 2014
I just tried the option @cgwyllie mentioned. It does clear the search text.
I think the default setting should be 'true'.
amcdnl commentedon Nov 19, 2014
@YidingW Ya, I agree too. I exposed a provider to be able to set it globally for my app. @dimirc why is it false by default?
iroa commentedon Dec 16, 2014
Setting the attribute did not work for me, but after some debugging I found some commented code that solved it when uncommented. So if I may ask, is there a reason why it is commented out?
// if(~[KEY.ESC,KEY.TAB].indexOf(key)){
// //TODO: SEGURO?
// ctrl.close();
// }
EpiphanyMachine commentedon Jan 29, 2015
+1 Uncommenting this solves the issue for me, thanks @iroa. If there is an invalid or empty input I want it to reset to the matched (model) option.
icfantv commentedon Feb 6, 2015
I can also confirm that adding the attribute does not work, but uncommenting the above code does.
jthibeaux commentedon Mar 6, 2015
+1
isamisushi commentedon Sep 9, 2015
+1
miyukiw commentedon Sep 9, 2015
+1
logstown commentedon Oct 7, 2015
+1
icfantv commentedon Oct 7, 2015
Hey guys, please refrain from only adding
+1
to issues. It adds nothing to the discussion and clutters up the thread. If you would like a feature implemented or bug fixed and it's not getting the attention you feel it deserves we do support user-supplied PRs.fabiowitt commentedon Dec 29, 2015
@iroa solution does work, but it loses the functionality of selecting an item when you press tab. The proper solution would be to clear it, only if no results were found.
mihai-vasilache commentedon Jun 5, 2016
I have the 0.17.1 version (released on 2016-05-16) and it is still not fixed. Do you have any intention to fix it?
user378230 commentedon Jun 8, 2016
@mihai-vasilache feel free to submit a PR that fixes the issue (including unit tests) will be happy to review and merge. 😃
ahocquet commentedon Jun 13, 2016
I came upon this issue today and I've made a PR to fix it : #1659
Feel free to test it and to give me your feedback !
Red-3 commentedon Dec 13, 2016
So @user378230 asks for a PR because too many people were +1-ing it (which I think means I agree, it's an issue for me too, please fix), @ahocquet provides said PR and still this remains an issue.
This has been open since Nov 2014. Update please?
annalauraaldlc commentedon May 4, 2017
+1
rajesh6291 commentedon Jun 15, 2017
+1