fix(@angular/build): correctly handle absolute paths and casing in test discovery

The `findTests` function's path normalization logic had two flaws that affected cross-platform compatibility and user experience:

1.  Absolute paths provided in the `include` patterns were incorrectly processed. The leading slash was removed, causing the globber to fail to find the specified test files.

2.  The prefix removal logic was case-sensitive, which would fail to normalize workspace-relative paths on case-insensitive filesystems (like Windows and macOS) if the user's input casing for the project path differed from the actual directory casing.

This commit corrects both issues:

- The `normalizePattern` function now uses `isAbsolute` to detect and preserve absolute paths, ensuring they are passed to the globber unmodified.
- The `removePrefix` helper function is now conditionally case-insensitive based on the host operating system (`win32`, `darwin`), aligning its behavior with the underlying filesystem and making path normalization more robust.
- Minor code style refactoring and JSDoc comments have been added for clarity.

Author: clydin

packages/angular/build/src/builders/karma/find-tests.ts

@@ -6,6 +6,27 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
+import { findTests as findTestsBase } from '../unit-test/test-discovery';
+
 // This file is a compatibility layer that re-exports the test discovery logic from its new location.
 // This is necessary to avoid breaking the Karma builder, which still depends on this file.
-export { findTests, getTestEntrypoints } from '../unit-test/test-discovery';
+export { getTestEntrypoints } from '../unit-test/test-discovery';
+
+const removeLeadingSlash = (path: string): string => {
+  return path.startsWith('/') ? path.substring(1) : path;
+};
+
+export async function findTests(
+  include: string[],
+  exclude: string[],
+  workspaceRoot: string,
+  projectSourceRoot: string,
+): Promise<string[]> {
+  // Karma has legacy support for workspace "root-relative" file paths
+  return findTestsBase(
+    include.map(removeLeadingSlash),
+    exclude.map(removeLeadingSlash),
+    workspaceRoot,
+    projectSourceRoot,
+  );
+}

packages/angular/build/src/builders/unit-test/test-discovery.ts

@@ -7,6 +7,7 @@
  */
 
 import { type PathLike, constants, promises as fs } from 'node:fs';
+import os from 'node:os';
 import { basename, dirname, extname, isAbsolute, join, relative } from 'node:path';
 import { glob, isDynamicPattern } from 'tinyglobby';
 import { toPosixPath } from '../../utils/path';
@@ -157,15 +158,32 @@ function generateNameFromPath(
   return result;
 }
 
-/** Removes a leading slash from a path. */
-const removeLeadingSlash = (path: string): string => {
-  return path.startsWith('/') ? path.substring(1) : path;
-};
+/**
+ * Whether the current operating system's filesystem is case-insensitive.
+ */
+const isCaseInsensitiveFilesystem = os.platform() === 'win32' || os.platform() === 'darwin';
 
-/** Removes a prefix from the beginning of a string. */
-const removePrefix = (str: string, prefix: string): string => {
-  return str.startsWith(prefix) ? str.substring(prefix.length) : str;
-};
+/**
+ * Removes a prefix from the beginning of a string, with conditional case-insensitivity
+ * based on the operating system's filesystem characteristics.
+ *
+ * @param text The string to remove the prefix from.
+ * @param prefix The prefix to remove.
+ * @returns The string with the prefix removed, or the original string if the prefix was not found.
+ */
+function removePrefix(text: string, prefix: string): string {
+  if (isCaseInsensitiveFilesystem) {
+    if (text.toLowerCase().startsWith(prefix.toLowerCase())) {
+      return text.substring(prefix.length);
+    }
+  } else {
+    if (text.startsWith(prefix)) {
+      return text.substring(prefix.length);
+    }
+  }
+
+  return text;
+}
 
 /**
  * Removes potential root paths from a file path, returning a relative path.
@@ -194,15 +212,18 @@ function removeRoots(path: string, roots: string[]): string {
  * @returns A normalized glob pattern.
  */
 function normalizePattern(pattern: string, projectRootPrefix: string): string {
-  let normalizedPattern = toPosixPath(pattern);
-  normalizedPattern = removeLeadingSlash(normalizedPattern);
+  const posixPattern = toPosixPath(pattern);
+
+  // Do not modify absolute paths. The globber will handle them correctly.
+  if (isAbsolute(posixPattern)) {
+    return posixPattern;
+  }
 
-  // Some IDEs and tools may provide patterns relative to the workspace root.
-  // To ensure the glob operates correctly within the project's source root,
-  // we remove the project's relative path from the front of the pattern.
-  normalizedPattern = removePrefix(normalizedPattern, projectRootPrefix);
+  // For relative paths, ensure they are correctly relative to the project source root.
+  // This involves removing the project root prefix if the user provided a workspace-relative path.
+  const normalizedRelative = removePrefix(posixPattern, projectRootPrefix);
 
-  return normalizedPattern;
+  return normalizedRelative;
 }
 
 /**