Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): keep background referenced HMR update chunks #29508

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix(@angular/build): keep background referenced HMR update chunks #29508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/angular/build/src/builders/application/build-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,15 @@ function* emitOutputResults(
};
}

// Do not remove stale files yet if there are template updates.
// Component chunk files may still be referenced in running browser code.
// Module evaluation time component updates will update any of these files.
// This typically occurs when a lazy component is changed that has not yet
// been accessed at runtime.
if (hasTemplateUpdates && incrementalResult.background) {
removedOutputFiles.clear();
}

// Include the removed output and asset files
incrementalResult.removed.push(
...Array.from(removedOutputFiles, ([file, { type }]) => ({
Expand Down