Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining SSR targets to rules_js jasmine test #29516

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

devversion
Copy link
Member

See individual commits

Currently the Windows job prints the `tar` command when extracting a
dependency, for every individual package.
Migrates the remaining `@angular/ssr` tests to `rules_js`.
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 29, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jan 29, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 29, 2025
@alan-agius4
Copy link
Collaborator

alan-agius4 commented Jan 29, 2025

@devversion, this will not merge cleanly in the patch branch.

@alan-agius4 alan-agius4 merged commit 539336e into angular:main Jan 29, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants