refactor(@angular/ssr): simplify preload append logic in metadata #29550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
simply-logic
branch
from
2116946 to
9c3f080
Compare
Replace `filter` and `map` with a `for...of` loop to improve readability in the preload append logic within metadata.
alan-agius4
force-pushed
the
simply-logic
branch
from
9c3f080 to
f85845b
Compare
clydin
approved these changes
Feb 3, 2025
clydin
added
action: merge
|
The changes were merged into the following branches: main, 19.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
filterandmapwith afor...ofloop to improve readability in the preload append logic within metadata.