Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

[pkg]: "postinstall": "tsd install" #240

Closed
@calebboyd

Description

@calebboyd

@mhevery, this statement breaks npm install for those who do not have tsd installed globally.

I'm not too sure how you'd like to alter that installation

Activity

cloudlena

cloudlena commented on Jan 29, 2016

@cloudlena

I agree. As a person using the newer typings instead of tsd, this breaks my installation.

cebor

cebor commented on Jan 29, 2016

@cebor

same here

psi-4ward

psi-4ward commented on Jan 30, 2016

@psi-4ward

+1

for now i npm i tsd

cebor

cebor commented on Jan 31, 2016

@cebor

strange thing is, that tsd is already added to devDeps

calebboyd

calebboyd commented on Jan 31, 2016

@calebboyd
Author

@cebor, the problem is that dev dependencies are not installed for consumers

cebor

cebor commented on Jan 31, 2016

@cebor

yes you are right, so i think its better to remove the postinstall and document the tsd install as a manual step for contributors

TheTedAdams

TheTedAdams commented on Feb 1, 2016

@TheTedAdams

+1 that this just broke our build.

postinstall tries to run tsd install on anyone installing this package from npm, which I don't think is what you were trying to do.

With tsd in devDependencies there is no guarantee tsd has been installed on the consumer. As a consumer I would also much rather postinstall was just removed, rather than adding a dependency on a successful tsd install. We have had tsd fail with API rate limiting so much that we have removed it from our build process and just added our typings folders to git...

PatrickJS

PatrickJS commented on Feb 3, 2016

@PatrickJS
Contributor

+1 postinstall breaks angular2 beta.3 unless tsd is installed as a dependency

added a commit that references this issue on Feb 3, 2016
c0f6033
Kikketer

Kikketer commented on Feb 3, 2016

@Kikketer

+1 Beta.3 fixes issues I have with multiple of the same components, but the dependency of installing tsd breaks my build on a build server. Moving back to beta.2 until this can be fixed.

jrisk

jrisk commented on Feb 4, 2016

@jrisk

same here, npm install tsd -g did fix the ERR messages atleast

20 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @mikekidder@alexeagle@mhevery@boneskull@Kikketer

    Issue actions

      [pkg]: "postinstall": "tsd install" · Issue #240 · angular/zone.js