Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename eq -> isEqual; cmp -> compare #165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename eq -> isEqual; cmp -> compare #165

wants to merge 1 commit into from

Conversation

janmasrovira
Copy link
Contributor

@janmasrovira janmasrovira commented Feb 13, 2025 •
edited
Loading

@janmasrovira janmasrovira self-assigned this Feb 13, 2025
@janmasrovira janmasrovira marked this pull request as ready for review February 13, 2025 16:19
@janmasrovira janmasrovira marked this pull request as draft February 13, 2025 16:23
@janmasrovira janmasrovira marked this pull request as ready for review February 13, 2025 16:25
@lukaszcz
Copy link
Contributor

I thought we solved the problem of failing tests with #161 and setting the stdlib to defaultStdlib in the juvix-quickcheck and juvix-test dependencies. Any idea why it might be failing again?

@janmasrovira
Copy link
Contributor Author

janmasrovira commented Feb 13, 2025 •
edited
Loading

@lukaszcz I think it's because juvix-quickcheck does not depend on the stdlib at ../. Rather, it depends on defaultStdlib, which is a different version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszcz lukaszcz lukaszcz approved these changes

Assignees

@janmasrovira janmasrovira

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename eq from Eq the trait to isEqual
2 participants
@janmasrovira @lukaszcz