Skip to content

Conversation

@siva-krishnaswamy
Copy link
Contributor

Description

** toolkit to review and modify project settings in single ui. Uses export config and import config functions in pyaedt. Exported config is displayed in a table. if modified, then imported back using import config**

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • [x ] I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • [x ] I have followed the coding style guidelines of this project.
  • [ x] I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • [x ] I have agreed with the Contributor License Agreement (CLA).

@siva-krishnaswamy siva-krishnaswamy requested a review from a team as a code owner August 6, 2025 08:22
@github-actions github-actions bot added the enhancement New features or code improvements label Aug 6, 2025
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 66.54611% with 185 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.96%. Comparing base (1bd1cb7) to head (d987401).
⚠️ Report is 1 commits behind head on main.

❌ Your patch check has failed because the patch coverage (66.54%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6495       +/-   ##
===========================================
- Coverage   83.49%   53.96%   -29.54%     
===========================================
  Files         245      248        +3     
  Lines       77510    78063      +553     
===========================================
- Hits        64717    42125    -22592     
- Misses      12793    35938    +23145     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys
Copy link
Member

Hi @siva-krishnaswamy @lorenzovecchietti ,

I think you missed the last update regarding extensions, we are in the middle of the refactoring of the extension to follow a common way, so we need you to refactor it in a proper way. Here you can find some guidelines:

https://aedt.docs.pyansys.com/version/stable/Getting_started/Contributing.html#extension-development-guide

And as you can see, it is an ongoing process, some extensions are migrated and others are not:
#6228

In summary, we are improving:

  1. Using the Common Extension Class to unify extension implementation.
  2. Testing the UI, now we are also adding the test of every action inside the UI.
  3. Improve documentation if possible.

Please reach out if you have comments.

@Samuelopez-ansys
Copy link
Member

@siva-krishnaswamy @lorenzovecchietti My previous message is not 100% correct, I see you are using the Common class, GREAT!

You just missed the unit tests, please check that we have system tests and unit tests, the latter tests the UI interaction. I put the PR in draft to not overload the CICD until the tests are ready.

@siva-krishnaswamy
Copy link
Contributor Author

@Samuelopez-ansys , Thanks . I will add system and unit test.

@siva-krishnaswamy siva-krishnaswamy marked this pull request as ready for review October 31, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants