-
Notifications
You must be signed in to change notification settings - Fork 201
FEAT: Icepak model reviewer extension #6495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…undary is not updated. So the project still shows the old value.
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (66.54%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6495 +/- ##
===========================================
- Coverage 83.49% 53.96% -29.54%
===========================================
Files 245 248 +3
Lines 77510 78063 +553
===========================================
- Hits 64717 42125 -22592
- Misses 12793 35938 +23145 🚀 New features to boost your workflow:
|
|
Hi @siva-krishnaswamy @lorenzovecchietti , I think you missed the last update regarding extensions, we are in the middle of the refactoring of the extension to follow a common way, so we need you to refactor it in a proper way. Here you can find some guidelines: And as you can see, it is an ongoing process, some extensions are migrated and others are not: In summary, we are improving:
Please reach out if you have comments. |
|
@siva-krishnaswamy @lorenzovecchietti My previous message is not 100% correct, I see you are using the Common class, GREAT! You just missed the unit tests, please check that we have system tests and unit tests, the latter tests the UI interaction. I put the PR in draft to not overload the CICD until the tests are ready. |
|
@Samuelopez-ansys , Thanks . I will add system and unit test. |
… feat/icepak_model_reviewer # Conflicts: # src/ansys/aedt/core/extensions/icepak/icepak_model_reviewer.py # src/ansys/aedt/core/extensions/icepak/icepak_model_reviewer/__init__.py # src/ansys/aedt/core/extensions/icepak/model_reviewer/backend.py
# Conflicts: # src/ansys/aedt/core/extensions/icepak/toolkits_catalog.toml
# Conflicts: # src/ansys/aedt/core/extensions/icepak/toolkits_catalog.toml
… feat/icepak_model_reviewer # Conflicts: # tests/unit/extensions/test_icepak_model_reviewer.py
… feat/icepak_model_reviewer
… feat/icepak_model_reviewer
… feat/icepak_model_reviewer
Description
** toolkit to review and modify project settings in single ui. Uses export config and import config functions in pyaedt. Exported config is displayed in a table. if modified, then imported back using import config**
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist