-
Notifications
You must be signed in to change notification settings - Fork 56
feat: Log from container when health-check fails #4599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances error diagnostics by logging Fluent container logs when initial health checks fail during container-based launches. This helps troubleshoot startup failures on remote machines where Fluent transcripts are not easily accessible.
Key Changes:
- Added exception handling around health check to capture and log container output when health checks fail
- Container stderr logs are now displayed in PyFluent output to expose Fluent startup errors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Context
When the initial health checks fails while launching Fluent, that usually means Fluent has encountered an error during the startup. The Fluent error is recorded in the Fluent transcript which cannot be accessed easily if we are running on a remote machine (like github runner).
Change Summary
If we are launching a Fluent container, the Fluent transcript is also copied to the container log. In this PR, the container error log is also logged in PyFluent when the initial health checks fails. Following is an example of pyfluent session when a wrong license server is set:
Rationale
For Fluent containers, we know the container id, so we can get the log. However, there is no good solution for standalone Fluent case as the transcript file name cannot be deterministically inferred from PyFluent.
Impact
This came up while triaging a container launch failure in a remote machine and will help such triaging in future.