Feat/add pymotorcad methods for transient (#327)

* added thermal option for save and load results

* added version check and input check for save and load results

* case sensitivity and message string changes

* case sensitivity and message string changes

* tests for thermal save and load

* Apply suggestions from code review

* improve test coverage

---------

Co-authored-by: Jack Davies <[email protected]>
Co-authored-by: Jack Davies <[email protected]>

Author: DragosVMosteanu

src/ansys/motorcad/core/methods/rpc_methods_general.py

@@ -21,6 +21,7 @@
 # SOFTWARE.
 
 """RPC methods (general)."""
+from ansys.motorcad.core.rpc_client_core import MotorCADError
 
 
 class _RpcMethodsGeneral:
@@ -378,31 +379,49 @@ def save_to_file(self, mot_file):
         return self.connection.send_and_receive(method, params)
 
     def save_results(self, solution_type):
-        """Save the output results from an ``"EMagnetic"`` solution.
+        """Save the output results from an ``"EMagnetic"`` or ``"Thermal"`` solution.
 
-        This method supports only ``"EMagnetic"`` solutions.
+        This method supports only ``"EMagnetic"`` or ``"Thermal"`` solutions.
 
         Parameters
         ----------
         solution_type : str
-            Soultion type, which must be ``"EMagnetic"``.
+            Solution type, which must be ``"EMagnetic"`` or ``"Thermal"``.
         """
         method = "SaveResults"
         params = [solution_type]
+
+        if solution_type.lower() == "thermal":
+            self.connection.ensure_version_at_least("2025.0")
+        elif solution_type.lower() != "emagnetic":
+            raise MotorCADError(
+                "Save results are not available for this solution type: "
+                + solution_type
+                + "\nAvailable solution types are: Thermal, EMagnetic"
+            )
         return self.connection.send_and_receive(method, params)
 
     def load_results(self, solution_type):
-        """Load the output results from an ``"EMagnetic"`` solution.
+        """Load the output results from an ``"EMagnetic"`` or ``"Thermal"`` solution.
 
-        This method supports only ``"EMagnetic"`` solution.
+        This method supports only ``"EMagnetic"`` or ``"Thermal"`` solution.
 
         Parameters
         ----------
         solution_type : str
-            Soultion type, which must be ``"EMagnetic"``.
+            Solution type, which must be ``"EMagnetic"`` or ``"Thermal"``.
         """
         method = "LoadResults"
         params = [solution_type]
+
+        if solution_type.lower() == "thermal":
+            self.connection.ensure_version_at_least("2025.0")
+        elif solution_type.lower() != "emagnetic":
+            raise MotorCADError(
+                "Load results are not available for this solution type: "
+                + solution_type
+                + "\nAvailable solution types are: Thermal, EMagnetic"
+            )
         return self.connection.send_and_receive(method, params)
 
     def load_magnetisation_curves(self, file_path):

tests/test_general.py

@@ -22,6 +22,8 @@
 
 import os
 
+import pytest
+
 from RPC_Test_Common import (
     almost_equal,
     get_base_test_file_path,
@@ -31,7 +33,7 @@
     reset_to_default_file,
 )
 import ansys.motorcad.core
-from ansys.motorcad.core import MotorCAD
+from ansys.motorcad.core import MotorCAD, MotorCADError
 
 # Allows us to add a new api method to testing before the next Motor-CAD release is available
 # Dev release will have a lower version number than actual release so don't want to check this
@@ -188,21 +190,39 @@ def test_save_load_magnetisation_curves(mc):
     reset_to_default_file(mc)
 
 
-def test_save_load_results():
+def test_save_load_results(mc):
     # Currently not working as part of full tests
     # Works individually - need to look into this
-    pass
-    # mc.do_magnetic_calculation()
-    # mc.save_results("EMagnetic")
-    # assert os.path.exists(get_temp_files_dir_path() + r"\temp_test_file\EMag\outputResults.mot")
-    # assert os.path.exists(get_temp_files_dir_path() + r"\temp_test_file\EMag\GraphResults.ini")
-    #
-    # mc.load_from_file(get_temp_files_dir_path() + r"\temp_test_file.mot")
-    #
-    # mc.load_results("EMagnetic")
-    # assert mc.get_variable("MaxTorque") != 0
-    #
-    # reset_to_default_file(mc)
+
+    # EMag test
+    mc.do_magnetic_calculation()
+    mc.save_results("EMagnetic")
+    assert os.path.exists(get_temp_files_dir_path() + r"\temp_test_file\EMag\outputResults.mot")
+    assert os.path.exists(get_temp_files_dir_path() + r"\temp_test_file\EMag\GraphResults.ini")
+
+    mc.load_from_file(get_temp_files_dir_path() + r"\temp_test_file.mot")
+
+    mc.load_results("EMagnetic")
+    assert mc.get_variable("MaxTorque") != 0
+
+    reset_to_default_file(mc)
+
+    # Thermal test - transient graphs only
+    mc.do_transient_analysis()
+    mc.save_results("Thermal")
+    assert os.path.exists(get_temp_files_dir_path() + r"\temp_test_file\Thermal\GraphResults.ini")
+
+    mc.load_from_file(get_temp_files_dir_path() + r"\temp_test_file.mot")
+
+    mc.load_results("TheRmal")
+    assert mc.get_power_graph_point("Armature Copper(Total)", 5) != 0
+
+    with pytest.raises(MotorCADError):
+        mc.load_results("wrong_type")
+
+    with pytest.raises(MotorCADError):
+        mc.save_results("wrong_type")
+    reset_to_default_file(mc)
 
 
 def test_get_message(mc):