Skip to content

Return explicit PreToolUse denial in security reminder #18513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxMiksa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return explicit PreToolUse denial in security reminder #18513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions plugins/security-guidance/hooks/security_reminder_hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ def main():
session_id = input_data.get("session_id", "default")
tool_name = input_data.get("tool_name", "")
tool_input = input_data.get("tool_input", {})
hook_event_name = input_data.get("hook_event_name", "PreToolUse")

# Check if this is a relevant tool
if tool_name not in ["Edit", "Write", "MultiEdit"]:
Expand Down Expand Up @@ -268,9 +269,16 @@ def main():
shown_warnings.add(warning_key)
save_state(session_id, shown_warnings)

# Output the warning to stderr and block execution
print(reminder, file=sys.stderr)
sys.exit(2) # Block tool execution (exit code 2 for PreToolUse hooks)
# Return explicit deny decision for PreToolUse
output = {
"hookSpecificOutput": {
"hookEventName": hook_event_name,
"permissionDecision": "deny",
},
"systemMessage": reminder,
}
print(json.dumps(output))
sys.exit(0)

# Allow tool to proceed
sys.exit(0)
Expand Down