Skip to content

Commit 6d3486e

Browse files
committed
Fix typescript errors
Remove rootDir from example/tsconfig.json Inclusion was causing TS6059 'rootDir' is expected to contain all source files error. Suggestion to remove from: wmonk/create-react-app-typescript#74 Change tsconfig.json compiler target to es7 With target set to es6, was receiving error: ERROR in /home/jthetzel/src/react-mapbox-gl/src/layer.ts (206,22): error TS2339: Property 'includes' does not exist on type 'number[]'. Suggestion to try es7: PatrickJS/PatrickJS-starter#931 (comment) Removing carets from devDependencies Presume this is preferred, as master branch does not use carets.
1 parent 598e437 commit 6d3486e

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

example/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
},
1313
"dependencies": {
1414
"immutable": "3.8.1",
15-
"react": "15.6.1",
16-
"react-dom": "15.6.1",
15+
"react": "16.0.0",
16+
"react-dom": "16.0.0",
1717
"react-live": "1.7.1",
1818
"react-router": "3.0.5",
1919
"styled-components": "2.1.2",

example/tsconfig.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
"noUnusedLocals": true,
1414
"outDir": "./dist",
1515
"removeComments": true,
16-
"rootDir": "./src",
1716
"sourceMap": true,
1817
"strictNullChecks": true,
1918
"suppressImplicitAnyIndexErrors": true,
@@ -23,4 +22,4 @@
2322
"node_modules",
2423
"static"
2524
]
26-
}
25+
}

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,15 +82,15 @@
8282
"@types/react-test-renderer": "^15.5.4",
8383
"@types/recompose": "0.24.1",
8484
"@types/supercluster": "^2.3.0",
85-
"enzyme": "^3.0.0",
85+
"enzyme": "3.0.0",
8686
"enzyme-adapter-react-16": "^1.0.0",
87-
"jest": "^21.2.0",
87+
"jest": "21.2.0",
8888
"mapbox-gl": "0.39.1",
8989
"prettier": "1.7.0",
9090
"prop-types": "15.5.10",
91-
"react": "^16.0.0",
92-
"react-dom": "^16.0.0",
93-
"react-test-renderer": "^16.0.0",
91+
"react": "16.0.0",
92+
"react-dom": "16.0.0",
93+
"react-test-renderer": "16.0.0",
9494
"recompose": "0.25.0",
9595
"ts-jest": "21.0.1",
9696
"tslint": "5.7.0",

0 commit comments

Comments
 (0)