Skip to content

Support crystal 1.0.0 #15

Open
Open
@erdnaxeli

Description

@erdnaxeli

Hi,

In order to support crystal 1 you need to set the supported crystal version in shards.yml to ">=0.3X.0, <2" (by default it assume "<1"). You also need to use ameba from crystal-ameba/ameba.

Activity

lbguilherme

lbguilherme commented on Aug 21, 2021

@lbguilherme

Hi @erdnaxeli!

I opened a PR that will fix this. Please take a look: #18

erdnaxeli

erdnaxeli commented on Aug 23, 2021

@erdnaxeli
Author

You PR does not fix the constraint on crystal <1 neither the ameba dependency :)

lbguilherme

lbguilherme commented on Aug 23, 2021

@lbguilherme
  • https://github.com/veelenga/ameba redirects to https://github.com/crystal-ameba/ameba, so the two are exactly the same and there is no visible difference for the user. The legacy name is supported.
  • shard.yml is not specifying a Crystal version, so by default shards install won't check and it will just work as the actual code compiles fine with Crystal 1+ now.

That said, I updated the PR with both points. Thanks!

erdnaxeli

erdnaxeli commented on Aug 23, 2021

@erdnaxeli
Author

shard.yml is not specifying a Crystal version, so by default shards install won't check

IIRC no specifying a crystal version means "< 1.0" (https://crystal-lang.org/2020/08/20/preparing-our-shards-for-crystal-1.0.html).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @erdnaxeli@lbguilherme

        Issue actions

          Support crystal 1.0.0 · Issue #15 · anykeyh/crystal-coverage