You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In order to support crystal 1 you need to set the supported crystal version in shards.yml to ">=0.3X.0, <2" (by default it assume "<1"). You also need to use ameba from crystal-ameba/ameba.
shard.yml is not specifying a Crystal version, so by default shards install won't check and it will just work as the actual code compiles fine with Crystal 1+ now.
That said, I updated the PR with both points. Thanks!
Activity
lbguilherme commentedon Aug 21, 2021
Hi @erdnaxeli!
I opened a PR that will fix this. Please take a look: #18
erdnaxeli commentedon Aug 23, 2021
You PR does not fix the constraint on crystal <1 neither the ameba dependency :)
lbguilherme commentedon Aug 23, 2021
shards install
won't check and it will just work as the actual code compiles fine with Crystal 1+ now.That said, I updated the PR with both points. Thanks!
erdnaxeli commentedon Aug 23, 2021
IIRC no specifying a crystal version means "< 1.0" (https://crystal-lang.org/2020/08/20/preparing-our-shards-for-crystal-1.0.html).