Bundlemon reports incorrect size deltas when using stacked PRs #70
Comments
|
Example PR that had an incorrect Bundlemon report: https://app.graphite.dev/github/pr/anza-xyz/solana-web3.js/69/Run-style-fix |
steveluscher
added a commit
that referenced
this issue
Jan 20, 2025
Stack this on top of `bundlemon-always-against-main` and see if Bundlemon reports the correct size. See #70
steveluscher
added a commit
that referenced
this issue
Mar 12, 2025
Regardless of what the mergebase of the current PR is, this will cause Bundlemon to _always_ compare the size from the perspective of the last known `main` size. This prevents stacked PRs from trying (and failing) to find the size of the PR branch directly underneath them. Fixes #70 # Test Plan Works on #72.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bundlemon is a CI step that compiles the code and then compares the size of key compiled bundles with the mergebase. Unfortunately when you stack a PR (ie. with Graphite) the mergebase is the PR before it. Bundlemon has no knowledge of such a branch and thinks that every file has been added anew.
The fix will be to get Bundlemon to use the root branch as the mergebase. Or I guess just always
main.The text was updated successfully, but these errors were encountered: