added validate method into TabletMetadata #5340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
reviewed
Feb 19, 2025
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
Outdated
Show resolved
Hide resolved
dlmarion
reviewed
Feb 19, 2025
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
Outdated
Show resolved
Hide resolved
keith-turner
approved these changes
May 6, 2025
Closed
keith-turner
added a commit
to keith-turner/accumulo
that referenced
this pull request
May 29, 2025
The delete rows table operation was clipping a file to a row range like (f,f] and adding this to tablet with a row range of (f,g]. The files row range did not overlap the tablets row range causing reads of the tablet to fail with the changes in apache#5340. This was causing DeleteRowsIT to fail, modified the code to avoid adding the non overlapping row range and now DeleteRowsIT passes. Made a lot of logging changes while tracking this down, kept those in this commit.
keith-turner
added a commit
to keith-turner/accumulo
that referenced
this pull request
May 29, 2025
CloneIT was directly inserting metadata table file entries with row ranges that did not overlap the tablet range. After the changes in apache#5340 this caused the metadata reads to fail. Modfied the test to insert file w/ ranges that overlap.
keith-turner
added a commit
that referenced
this pull request
May 29, 2025
CloneIT was directly inserting metadata table file entries with row ranges that did not overlap the tablet range. After the changes in #5340 this caused the metadata reads to fail. Modfied the test to insert file w/ ranges that overlap.
keith-turner
added a commit
that referenced
this pull request
May 30, 2025
The delete rows table operation was clipping a file to a row range like (f,f] and adding this to tablet with a row range of (f,g]. The files row range did not overlap the tablets row range causing reads of the tablet to fail with the changes in #5340. This was causing DeleteRowsIT to fail, modified the code to avoid adding the non overlapping row range and now DeleteRowsIT passes. Made a lot of logging changes while tracking this down, kept those in this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue #5242
Created a Validate method inside Tablet Metadata to check overlap of files and tablet ranges.