Add deepCopy to VisibilityFilter #5385
Merged
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganasherjones
force-pushed
the
issue-5372-2.1
branch
from
656f96f to
3f5f707
Compare
ivakegg
approved these changes
Aug 12, 2025
There was a problem hiding this comment.
This deepcopy does not do a deepcopy of the evaluator or the cache but I think that is OK in this case as those can be reused and appended to by multiple instances of this source. A key note is that the copies will NOT be thread safe but that is usually not a concern as iterator should not be multi-threaded themselves for the most part.
|
I'll merge this commit, based on @ivakegg 's comments. I agree that a deep copy of the evaluator and cache are probably not needed here (since the options don't change). If thread safety is needed, we can consider additional PRs at that time, to create a fresh copy of the evaluator and cache for the deep copy of this. This fixes the reported NPE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
deepCopymethod to the userVisibilityFilteriterator.This is a demonstration of how to solve #5372.