Skip to content

GH-499: Require PR labels for changelog#594

Merged
lidavidm merged 9 commits intoapache:mainfrom
lidavidm:gh-499
Feb 18, 2025
Merged

GH-499: Require PR labels for changelog#594
lidavidm merged 9 commits intoapache:mainfrom
lidavidm:gh-499

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Feb 7, 2025 •
edited
Loading

  • Validate that at least one of certain labels are present on a PR.
  • Validate the format of the title.
  • Add label for things that are not dependencies but are other chores (release/build work).
  • Add label for documentation updates.
  • Validate that a PR titled GH-499 is actually linked to issue #499 by poking the GitHub API.
  • Add the GitHub config to use these labels for changelog generation.

Closes #499.

@lidavidm lidavidm mentioned this pull request Feb 7, 2025
Closed
@jbonofre jbonofre self-requested a review February 7, 2025 15:37
@jbonofre
Copy link
Member

jbonofre commented Feb 7, 2025

It looks good. Maybe we should also update the GitHub PR Template to "strongly" emphasize on issue ?

@lidavidm
Copy link
Member Author

lidavidm commented Feb 8, 2025

Will do.

It looks like you can't have selectors in pull request templates like you can in issues, but looks like we could add a set of checkboxes and have the action populate the labels based on that instead (or something similar)

@jbonofre
Copy link
Member

jbonofre commented Feb 8, 2025

Yes. It's what I have in mind.

@lidavidm
Copy link
Member Author

lidavidm commented Feb 10, 2025

Example run: https://github.com/lidavidm/arrow-java/actions/runs/13234776842/job/36937648586

kou
kou reviewed Feb 10, 2025
View reviewed changes
@lidavidm
Copy link
Member Author

lidavidm commented Feb 13, 2025

I've updated this with an action that checks the title, linked issue, and labels.

Demo here: lidavidm#6

If missing a label it will make a comment, when the label is added it will hide the comment.

@lidavidm lidavidm marked this pull request as ready for review February 13, 2025 04:32
kou
kou approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Let's try this!

lidavidm and others added 3 commits February 13, 2025 00:58
@lidavidm @kou
Update .github/workflows/dev_pr.yml
d4075c1 
Co-authored-by: Sutou Kouhei <[email protected]>
@lidavidm @kou
Update CONTRIBUTING.md
ac75e64 
Co-authored-by: Sutou Kouhei <[email protected]>
@lidavidm @kou
Update CONTRIBUTING.md
e46f293 
Co-authored-by: Sutou Kouhei <[email protected]>
@lidavidm lidavidm merged commit 52cf1f2 into apache:main Feb 18, 2025
25 checks passed
@lidavidm lidavidm added this to the 18.3.0 milestone Feb 18, 2025
@lidavidm lidavidm added the enhancement PRs that add or improve features. label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

@laurentgo laurentgo Awaiting requested review from laurentgo laurentgo is a code owner

@wgtmac wgtmac Awaiting requested review from wgtmac wgtmac is a code owner

Assignees

No one assigned

Labels

enhancement PRs that add or improve features.

Projects

None yet

Milestone

18.3.0

Development

Successfully merging this pull request may close these issues.

[Release] How to create release note?

3 participants

@lidavidm @jbonofre @kou