Skip to content

Commit 2c90daf

Browse files
authored
GH-39023: [C++][CMake] Add missing launcher path conversion for ExternalPackage (#45349)
### Rationale for this change We need to convert it on Windows. ### What changes are included in this PR? Convert it to CMake path. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #39023 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
1 parent c6b6bfb commit 2c90daf

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -988,9 +988,11 @@ endif()
988988

989989
# Enable s/ccache if set by parent.
990990
if(CMAKE_C_COMPILER_LAUNCHER AND CMAKE_CXX_COMPILER_LAUNCHER)
991+
file(TO_CMAKE_PATH "${CMAKE_C_COMPILER_LAUNCHER}" EP_CMAKE_C_COMPILER_LAUNCHER)
992+
file(TO_CMAKE_PATH "${CMAKE_CXX_COMPILER_LAUNCHER}" EP_CMAKE_CXX_COMPILER_LAUNCHER)
991993
list(APPEND EP_COMMON_CMAKE_ARGS
992-
-DCMAKE_C_COMPILER_LAUNCHER=${CMAKE_C_COMPILER_LAUNCHER}
993-
-DCMAKE_CXX_COMPILER_LAUNCHER=${CMAKE_CXX_COMPILER_LAUNCHER})
994+
-DCMAKE_C_COMPILER_LAUNCHER=${EP_CMAKE_C_COMPILER_LAUNCHER}
995+
-DCMAKE_CXX_COMPILER_LAUNCHER=${EP_CMAKE_CXX_COMPILER_LAUNCHER})
994996
endif()
995997

996998
if(NOT ARROW_VERBOSE_THIRDPARTY_BUILD)

0 commit comments

Comments
 (0)