Skip to content

Commit f4b7a4e

Browse files
authored
GH-45930: [C++] Don't use ICU C++ API in Azure SDK C++ (#45952)
### Rationale for this change ICU 75.1 or later requires C++17 but Azure SDK for C++ still uses C++14. Azure SDK for C++ includes ICU headers via libxml2. ### What changes are included in this PR? We don't need to use ICU C++ API. So we can disable ICU C++ API. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #45930 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
1 parent 2f4f68a commit f4b7a4e

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5510,6 +5510,12 @@ function(build_azure_sdk)
55105510
set(BUILD_SAMPLES FALSE)
55115511
set(BUILD_TESTING FALSE)
55125512
set(BUILD_WINDOWS_UWP TRUE)
5513+
# ICU 75.1 or later requires C++17 but Azure SDK for C++ still uses
5514+
# C++14. So we disable C++ API in ICU.
5515+
#
5516+
# We can remove this after
5517+
# https://github.com/Azure/azure-sdk-for-cpp/pull/6486 is merged.
5518+
string(APPEND CMAKE_CXX_FLAGS " -DU_SHOW_CPLUSPLUS_API=0")
55135519
set(CMAKE_UNITY_BUILD FALSE)
55145520
set(DISABLE_AZURE_CORE_OPENTELEMETRY TRUE)
55155521
set(ENV{AZURE_SDK_DISABLE_AUTO_VCPKG} TRUE)

0 commit comments

Comments
 (0)