Fix ThreadSanitizer data races between bundle processing and async background writer closing in FileBasedSink and WriteFiles #34763
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Licensed to the Apache Software Foundation (ASF) under one or more | |
| # contributor license agreements. See the NOTICE file distributed with | |
| # this work for additional information regarding copyright ownership. | |
| # The ASF licenses this file to You under the Apache License, Version 2.0 | |
| # (the "License"); you may not use this file except in compliance with | |
| # the License. You may obtain a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, software | |
| # distributed under the License is distributed on an "AS IS" BASIS, | |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| # See the License for the specific language governing permissions and | |
| # limitations under the License. | |
| name: PreCommit Python ML tests with ML deps installed | |
| on: | |
| pull_request_target: | |
| branches: [ "master", "release-*" ] | |
| paths: [ "model/**","sdks/python/**","release/**", 'release/trigger_all_tests.json', '.github/trigger_files/beam_PreCommit_Python_ML.json'] | |
| issue_comment: | |
| types: [created] | |
| push: | |
| tags: ['v*'] | |
| branches: ['master', 'release-*'] | |
| paths: [ "model/**","sdks/python/**","release/**",".github/workflows/beam_PreCommit_Python_ML.yml"] | |
| schedule: | |
| - cron: '45 2/6 * * *' | |
| workflow_dispatch: | |
| #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event | |
| permissions: | |
| actions: write | |
| pull-requests: write | |
| checks: write | |
| contents: read | |
| deployments: read | |
| id-token: none | |
| issues: write | |
| discussions: read | |
| packages: read | |
| pages: read | |
| repository-projects: read | |
| security-events: read | |
| statuses: read | |
| # This allows a subsequently queued workflow run to interrupt previous runs | |
| concurrency: | |
| group: '${{ github.workflow }} @ ${{ github.event.pull_request.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login }}' | |
| cancel-in-progress: true | |
| env: | |
| DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} | |
| GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }} | |
| GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }} | |
| ALLOYDB_PASSWORD: ${{ secrets.ALLOYDB_PASSWORD }} | |
| jobs: | |
| beam_PreCommit_Python_ML: | |
| name: ${{ matrix.job_name }} (${{ matrix.job_phrase }} ${{ matrix.python_version }}) (${{ join(matrix.os, ', ') }}) | |
| runs-on: ${{ matrix.os }} | |
| timeout-minutes: 180 | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| job_name: ['beam_PreCommit_Python_ML'] | |
| job_phrase: ['Run Python_ML PreCommit'] | |
| python_version: ['3.10','3.11','3.12','3.13'] | |
| # Run on both self-hosted and GitHub-hosted runners. | |
| # Some tests (marked require_docker_in_docker) can't run on Beam's | |
| # self-hosted runners due to Docker-in-Docker environment constraint. | |
| # These tests will only execute on ubuntu-latest (GitHub-hosted). | |
| # Context: https://github.com/apache/beam/pull/35585. | |
| os: [[self-hosted, ubuntu-24.04, main], [ubuntu-latest]] | |
| exclude: | |
| # exercise DinD tests (needed for Milvus) for latest Python version | |
| - python_version: '3.10' | |
| os: [ubuntu-latest] | |
| - python_version: '3.11' | |
| os: [ubuntu-latest] | |
| - python_version: '3.12' | |
| os: [ ubuntu-latest ] | |
| if: | | |
| github.event_name == 'push' || | |
| github.event_name == 'pull_request_target' || | |
| (github.event_name == 'schedule' && github.repository == 'apache/beam') || | |
| github.event_name == 'workflow_dispatch' || | |
| startsWith(github.event.comment.body, 'Run Python_ML PreCommit') | |
| steps: | |
| - uses: actions/checkout@v7 | |
| with: | |
| persist-credentials: false | |
| - name: Free Disk Space (Ubuntu) | |
| if: contains(matrix.os, 'ubuntu-latest') | |
| uses: jlumbroso/free-disk-space@v1.3.1 | |
| with: | |
| # Remove unnecessary packages to free up space | |
| tool-cache: false | |
| android: true | |
| dotnet: true | |
| haskell: true | |
| large-packages: true | |
| docker-images: true | |
| swap-storage: true | |
| - name: Setup repository | |
| uses: ./.github/actions/setup-action | |
| with: | |
| comment_phrase: ${{ matrix.job_phrase }} ${{ matrix.python_version }} | |
| github_token: ${{ secrets.GITHUB_TOKEN }} | |
| github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }} ${{ matrix.python_version }}) (${{ join(matrix.os, ', ') }}) | |
| - name: Setup environment | |
| uses: ./.github/actions/setup-environment-action | |
| with: | |
| java-version: default | |
| python-version: ${{ matrix.python_version }} | |
| - name: Set PY_VER_CLEAN | |
| id: set_py_ver_clean | |
| run: | | |
| PY_VER=${{ matrix.python_version }} | |
| PY_VER_CLEAN=${PY_VER//.} | |
| echo "py_ver_clean=$PY_VER_CLEAN" >> $GITHUB_OUTPUT | |
| - name: Run pythonPreCommit | |
| uses: ./.github/actions/gradle-command-self-hosted-action | |
| with: | |
| gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:testPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}ML | |
| arguments: | | |
| -Pposargs="${{ | |
| contains(matrix.os, 'self-hosted') && | |
| 'apache_beam/ml/ -m (not require_docker_in_docker)' || | |
| 'apache_beam/ml/ -m require_docker_in_docker' | |
| }}" \ | |
| -PpythonVersion=${{ matrix.python_version }} | |
| - name: Archive Python Test Results | |
| uses: actions/upload-artifact@v7 | |
| if: failure() | |
| with: | |
| name: Python ${{ matrix.python_version }} Test Results ${{ matrix.os }} | |
| path: '**/pytest*.xml' | |
| - name: Publish Python Test Results | |
| uses: EnricoMi/publish-unit-test-result-action@v2 | |
| if: always() | |
| with: | |
| commit: '${{ env.prsha || env.GITHUB_SHA }}' | |
| comment_mode: ${{ github.event_name == 'issue_comment' && 'always' || 'off' }} | |
| files: '**/pytest*.xml' | |
| large_files: true | |
| check_name: "Python ${{ matrix.python_version }} Test Results (${{ join(matrix.os, ', ') }})" |