Skip to content

Fix ThreadSanitizer data races between bundle processing and async background writer closing in FileBasedSink and WriteFiles #3640

Fix ThreadSanitizer data races between bundle processing and async background writer closing in FileBasedSink and WriteFiles

Fix ThreadSanitizer data races between bundle processing and async background writer closing in FileBasedSink and WriteFiles #3640

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or or in writing, software
# distributed under the License is distributed on an "AS IS"
# BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
# express or implied. See the License for the specific language
# governing permissions and limitations under the License.
name: PreCommit Java Dataflow Non-portable Worker
on:
push:
tags: ['v*']
branches: ['master', 'release-*']
paths:
- 'runners/google-cloud-dataflow-java/worker/**'
- '.github/workflows/beam_PreCommit_Java_Dataflow.yml'
pull_request_target:
branches: ['master', 'release-*']
paths:
- 'runners/google-cloud-dataflow-java/worker/**'
- '.github/trigger_files/beam_PreCommit_Java_Dataflow.json'
- '.github/workflows/beam_PreCommit_Java_Dataflow.yml'
- 'release/trigger_all_tests.json'
issue_comment:
types: [created]
schedule:
- cron: '30 2/6 * * *'
workflow_dispatch:
concurrency:
group: '${{ github.workflow }} @ ${{ github.event.pull_request.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login }}'
cancel-in-progress: true
permissions:
actions: write
pull-requests: write
checks: write
contents: read
deployments: read
id-token: none
issues: write
discussions: read
packages: read
pages: read
repository-projects: read
security-events: read
statuses: read
env:
DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
jobs:
beam_PreCommit_Java_Dataflow:
name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
runs-on: [self-hosted, ubuntu-24.04, main]
strategy:
fail-fast: false
matrix:
job_name: [beam_PreCommit_Java_Dataflow_NonportableWorker]
job_phrase: [Run Java Dataflow Non-portable Worker PreCommit]
timeout-minutes: 240
if: |
github.event_name == 'push' ||
github.event_name == 'pull_request_target' ||
(github.event_name == 'schedule' && github.repository == 'apache/beam') ||
github.event_name == 'workflow_dispatch' ||
github.event.comment.body == 'Run Java Dataflow Non-portable Worker PreCommit'
steps:
- uses: actions/checkout@v7
with:
persist-credentials: false
- name: Setup repository
uses: ./.github/actions/setup-action
with:
comment_phrase: ${{ matrix.job_phrase }}
github_token: ${{ secrets.GITHUB_TOKEN }}
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
- name: Setup environment
uses: ./.github/actions/setup-environment-action
with:
python-version: default
disable-cache: true
- name: Run Dataflow Worker tests
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: build
arguments: |
-p runners/google-cloud-dataflow-java/worker \
-PdisableSpotlessCheck=true \
-PdisableCheckStyle=true \
-PenableJacocoReport
- name: Archive JUnit Test Results
uses: actions/upload-artifact@v7
if: ${{ !success() }}
with:
name: JUnit Test Results
path: "**/build/reports/tests/"
- name: Publish JUnit Test Results
uses: EnricoMi/publish-unit-test-result-action@v2
if: always()
with:
commit: '${{ env.prsha || env.GITHUB_SHA }}'
comment_mode: ${{ github.event_name == 'issue_comment' && 'always' || 'off' }}
files: '**/build/test-results/**/*.xml'
large_files: true
- name: Archive SpotBugs Results
uses: actions/upload-artifact@v7
if: always()
with:
name: SpotBugs Results
path: '**/build/reports/spotbugs/*.html'
- name: Publish SpotBugs Results
uses: jwgmeligmeyling/spotbugs-github-action@v1.2
if: always()
with:
name: Publish SpotBugs
path: '**/build/reports/spotbugs/*.html'
- name: Archive Jacoco Results
uses: actions/upload-artifact@v7
with:
name: Jacoco Results
path: '**/build/jacoco/report/**'
- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v3
with:
flags: java