Skip to content

Commit 3e28e52

Browse files
committed
revert prior changes
1 parent d05d3b8 commit 3e28e52

5 files changed

Lines changed: 6 additions & 56 deletions

File tree

.github/workflows/beam_PreCommit_Spotless.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@ jobs:
7777
github.event.comment.body == 'Run Spotless PreCommit'
7878
steps:
7979
- uses: actions/checkout@v6
80-
with:
81-
fetch-depth: 0
8280
- name: Setup repository
8381
uses: ./.github/actions/setup-action
8482
with:
@@ -87,14 +85,11 @@ jobs:
8785
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
8886
- name: Setup environment
8987
uses: ./.github/actions/setup-environment-action
90-
with:
91-
java-version: '17'
9288
- name: run Spotless PreCommit script
9389
uses: ./.github/actions/gradle-command-self-hosted-action
9490
with:
9591
gradle-command: spotlessCheck checkStyleMain checkStyleTest :buildSrc:spotlessCheck
96-
arguments: -PdisableSpotlessApply ${{ github.event_name == 'schedule' && '-PdisableSpotlessRatchet=true' || '' }}
97-
max-workers: 4
92+
arguments: -PdisableSpotlessApply
9893
- name: Upload test report
9994
uses: actions/upload-artifact@v7
10095
with:

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

Lines changed: 2 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -508,40 +508,7 @@ class BeamModulePlugin implements Plugin<Project> {
508508

509509
project.ext.mavenGroupId = 'org.apache.beam'
510510

511-
project.ext.getRatchetBranch = {
512-
->
513-
if (project.hasProperty('disableSpotlessRatchet') && project.disableSpotlessRatchet == 'true') {
514-
return null
515-
}
516-
try {
517-
def checkRef = { ref ->
518-
try {
519-
def res = project.exec {
520-
executable 'git'
521-
args 'rev-parse', '--verify', ref
522-
ignoreExitValue = true
523-
standardOutput = new ByteArrayOutputStream()
524-
errorOutput = new ByteArrayOutputStream()
525-
}
526-
return res.getExitValue() == 0
527-
} catch (Exception e) {
528-
return false
529-
}
530-
}
531511

532-
if (checkRef('upstream/master')) {
533-
return 'upstream/master'
534-
} else if (checkRef('origin/master')) {
535-
return 'origin/master'
536-
} else if (checkRef('master')) {
537-
return 'master'
538-
} else {
539-
return null
540-
}
541-
} catch (Exception e) {
542-
return null
543-
}
544-
}
545512
// Default to dash-separated directories for artifact base name,
546513
// which will also be the default artifactId for maven publications
547514
project.apply plugin: 'base'
@@ -1501,10 +1468,7 @@ class BeamModulePlugin implements Plugin<Project> {
15011468
project.disableSpotlessCheck == 'true'
15021469
project.spotless {
15031470
enforceCheck !disableSpotlessCheck
1504-
def ratchetBranch = project.ext.getRatchetBranch()
1505-
if (ratchetBranch != null) {
1506-
ratchetFrom ratchetBranch
1507-
}
1471+
15081472
java {
15091473
licenseHeader javaLicenseHeader
15101474
googleJavaFormat('1.17.0')
@@ -2427,10 +2391,7 @@ class BeamModulePlugin implements Plugin<Project> {
24272391
project.disableSpotlessCheck == 'true'
24282392
project.spotless {
24292393
enforceCheck !disableSpotlessCheck
2430-
def ratchetBranch = project.ext.getRatchetBranch()
2431-
if (ratchetBranch != null) {
2432-
ratchetFrom ratchetBranch
2433-
}
2394+
24342395
def grEclipseConfig = project.project(":").file("buildSrc/greclipse.properties")
24352396
groovy {
24362397
greclipse().configFile(grEclipseConfig)

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ org.gradle.caching=true
1919
org.gradle.parallel=true
2020
org.gradle.daemon=false
2121
org.gradle.configureondemand=true
22-
org.gradle.jvmargs=-Xmx6g -Xss10240k -XX:+UseG1GC
22+
org.gradle.jvmargs=-Xss10240k
2323
org.gradle.vfs.watch=true
2424
offlineRepositoryRoot=offline-repository
2525
signing.gnupg.executable=gpg

runners/flink/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,7 @@ repositories {
2828
* We configure spotless here once in order to only check these java sources once.
2929
*/
3030
spotless {
31-
def ratchetBranch = project.rootProject.hasProperty('getRatchetBranch') ? project.rootProject.ext.getRatchetBranch() : null
32-
if (ratchetBranch != null) {
33-
ratchetFrom ratchetBranch
34-
}
31+
3532
java {
3633
licenseHeader org.apache.beam.gradle.BeamModulePlugin.javaLicenseHeader
3734
googleJavaFormat('1.17.0')

runners/spark/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,7 @@ repositories {
2828
* We configure spotless here once in order to only check these java sources once.
2929
*/
3030
spotless {
31-
def ratchetBranch = project.rootProject.hasProperty('getRatchetBranch') ? project.rootProject.ext.getRatchetBranch() : null
32-
if (ratchetBranch != null) {
33-
ratchetFrom ratchetBranch
34-
}
31+
3532
java {
3633
licenseHeader org.apache.beam.gradle.BeamModulePlugin.javaLicenseHeader
3734
googleJavaFormat('1.17.0')

0 commit comments

Comments
 (0)