Exclude testSideInputNotReadyTimer from Spark batch suites - #38939
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Spark runner configuration to skip a specific test case that is not supported by the current implementation. By excluding 'testSideInputNotReadyTimer' from the Spark batch suites, the build process will avoid failures related to unsupported timer functionality. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request excludes the testSideInputNotReadyTimer test from the Spark runner and job server test suites because Spark does not support side inputs in timers. The reviewer suggests tracking these exclusions by creating a GitHub issue and adding a corresponding TODO comment with the issue link, maintaining consistency with other test exclusions in the codebase.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| excludeTestsMatching 'org.apache.beam.sdk.transforms.FlattenTest.testFlattenWithDifferentInputAndOutputCoders2' | ||
| // TODO(https://github.com/apache/beam/issues/31231) | ||
| excludeTestsMatching 'org.apache.beam.sdk.transforms.RedistributeTest.testRedistributePreservesMetadata' | ||
| // Spark does not support side inputs in timers (added in #38363) |
There was a problem hiding this comment.
To ensure this test exclusion is tracked and eventually resolved, please create a GitHub issue and reference it with a TODO comment, following the pattern used elsewhere in this file.
// TODO(https://github.com/apache/beam/issues/XXXXX) Spark does not support side inputs in timers
| excludeTestsMatching 'org.apache.beam.sdk.transforms.RedistributeTest.testRedistributePreservesMetadata' | ||
| // TODO(https://github.com/apache/beam/issues/32021) | ||
| excludeTestsMatching 'org.apache.beam.sdk.metrics.MetricsTest$AttemptedMetricTests.testBoundedSourceMetricsInSplit' | ||
| // Spark does not support side inputs in timers (added in #38363) |
There was a problem hiding this comment.
Please use a TODO comment with a GitHub issue link to track the enablement of this test, consistent with other test exclusions in this file.
// TODO(https://github.com/apache/beam/issues/XXXXX) Spark does not support side inputs in timers
|
cc: @Abacn |
|
Assigning reviewers: R: @damccorm added as fallback since no labels match configuration Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
2 participants
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.