Skip to content

Add Dynamic Schema support to StorageWriteToBigQuery#39236

Open
jrmccluskey wants to merge 15 commits into
apache:masterfrom
jrmccluskey:dynamicDuo
Open

Add Dynamic Schema support to StorageWriteToBigQuery#39236
jrmccluskey wants to merge 15 commits into
apache:masterfrom
jrmccluskey:dynamicDuo

Conversation

@jrmccluskey

Copy link
Copy Markdown
Contributor

Implements support for using dynamic schemas in StorageWriteToBigQuery invocations.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@jrmccluskey

Copy link
Copy Markdown
Contributor Author

/gemini review

@apache apache deleted a comment from gemini-code-assist Bot Jul 8, 2026
@apache apache deleted a comment from gemini-code-assist Bot Jul 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for dynamic schemas and schema side inputs when writing to BigQuery using the Storage Write API (StorageWriteToBigQuery). It includes updates to handle callable schemas, passes schema side inputs through the pipeline, adds validation to ensure dynamic schemas are only used with dynamic destinations, and provides comprehensive unit and integration tests. There are no review comments, and the implementation looks solid, so I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for dynamic schemas when writing to dynamic destinations using the BigQuery Storage Write API, including a new dynamic_schema helper function, updates to StorageWriteToBigQuery to handle dynamic schemas and side inputs, and comprehensive unit tests. The reviewer feedback highlights critical issues that need to be addressed: potential runtime NameError exceptions from referencing the bigquery module namespace within bigquery.py, unintended in-place mutation of user-provided schemas during merging, and potential serialization/encoding errors (CoderException) alongside performance overhead caused by dynamic beam.Row instantiation with None values.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sdks/python/apache_beam/io/gcp/bigquery.py
Comment thread sdks/python/apache_beam/io/gcp/bigquery.py
Comment thread sdks/python/apache_beam/io/gcp/bigquery.py
Comment thread sdks/python/apache_beam/io/gcp/bigquery.py
jrmccluskey and others added 3 commits July 21, 2026 11:05
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@jrmccluskey jrmccluskey changed the title [WIP] Add Dynamic Schema support to StorageWriteToBigQuery Add Dynamic Schema support to StorageWriteToBigQuery Jul 21, 2026
@jrmccluskey
jrmccluskey marked this pull request as ready for review July 21, 2026 20:05
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @shunping for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant