Fix PreCommit IOs with Java11#39343
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses compatibility issues encountered during PreCommit IO tasks when using newer Java versions. By dynamically adjusting compiler arguments based on the target Java version, it ensures that generated code, such as ANTLR-produced classes, does not trigger unnecessary linting errors related to 'this-escape' when building with older Java targets on modern JDKs. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies 'BeamModulePlugin.groovy' to conditionally remove the '-Xlint:-this-escape' compiler argument when compiling with Java 21+ for target versions lower than 21. The reviewer suggested simplifying the version comparison using Groovy's native comparison operators and using 'JavaVersion.toVersion("21")' instead of 'JavaVersion.VERSION_21' to ensure compatibility with older Gradle versions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| } | ||
| // TODO(yathu): remove this once generated code (antlr) no longer trigger "this-escape", see above | ||
| // Unpin global opts when ver is lower than current | ||
| if (JavaVersion.current().compareTo(JavaVersion.VERSION_21) >= 0 && JavaVersion.toVersion(ver) < JavaVersion.VERSION_21) { |
There was a problem hiding this comment.
In Groovy, we can use native comparison operators (>=, <) on Comparable objects like JavaVersion instead of verbose .compareTo(...) calls. Additionally, using JavaVersion.toVersion('21') instead of JavaVersion.VERSION_21 is safer and prevents potential runtime errors on older Gradle versions (prior to 8.4) that do not define JavaVersion.VERSION_21.
if (JavaVersion.current() >= JavaVersion.toVersion('21') && JavaVersion.toVersion(ver) < JavaVersion.toVersion('21')) {
|
R: @aIbrahiim |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
R: @shunping |
2 participants
Please add a meaningful description for your change here
Fix #39268
Fix PreComit Java IOs
Tested locally with bash default to Java 21 then run
./gradlew :sdks:java:io:hbase:build -Pjava11Home=<...> -PtestJavaVersion=11Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.