Debezium IO yaml - #39457
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39457 +/- ##
============================================
+ Coverage 54.78% 54.85% +0.06%
Complexity 1716 1716
============================================
Files 1069 1070 +1
Lines 169121 169488 +367
Branches 1255 1255
============================================
+ Hits 92654 92970 +316
- Misses 74251 74302 +51
Partials 2216 2216
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| // TODO(pabloem): Database connection issues can be debugged here. | ||
| Schema recordSchema = readTransform.getRecordSchema(); | ||
| Schema recordSchema = withoutOptions(readTransform.getRecordSchema()); |
There was a problem hiding this comment.
Why need "withoutOptions" here? Any risk of breaking changes?
There was a problem hiding this comment.
withoutOptions removes the primaryKeyColumns schema option because the Python SDK cannot decode it across the Java/Python expansion boundary. It does not change the output fields or row values, and the regular Java DebeziumIO schema remains unchanged. The only difference is that this metadata is not exposed through the SchemaTransform.
| .withMaxNumberOfRecords(testLimitRecords) | ||
| .withMaxTimeToRun(testLimitMilliseconds); | ||
| } else { | ||
| Integer maxNumberOfRecords = configuration.getMaxNumberOfRecords(); |
There was a problem hiding this comment.
Shall we treat zero the same as null?
There was a problem hiding this comment.
I would keep null as “no limit”, and reject zero
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
@Abacn Could you please review |
Already did, please see the comments above |
|
Assigning reviewers: R: @jrmccluskey for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Resolves #28687
Successful test: https://github.com/apache/beam/actions/runs/30355812126
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.